Fix data race on prefetcher. #17678
Closed
Fix data race on prefetcher. #17678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
approved these changes
Mar 7, 2023
sgowroji
added
the
team-Remote-Exec
|
Should this land in 6.2 as well (asking more if it's broken in 6.x)? |
|
@bazel-io fork 6.2.0 |
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext.
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 10, 2023
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext. Closes bazelbuild#17678. PiperOrigin-RevId: 515024483 Change-Id: Ic8097979d06ab143b4d63f5e90f871f8cbf83959
tjgq
added a commit
to tjgq/bazel
that referenced
this pull request
Mar 11, 2023
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext. Closes bazelbuild#17678. PiperOrigin-RevId: 515024483 Change-Id: Ic8097979d06ab143b4d63f5e90f871f8cbf83959
ShreeM01
added a commit
that referenced
this pull request
Mar 13, 2023
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext. Closes #17678. PiperOrigin-RevId: 515024483 Change-Id: Ic8097979d06ab143b4d63f5e90f871f8cbf83959 Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
fweikert
pushed a commit
that referenced
this pull request
Mar 17, 2023
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext. Closes #17678. PiperOrigin-RevId: 515024483 Change-Id: Ic8097979d06ab143b4d63f5e90f871f8cbf83959
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext. Closes bazelbuild#17678. PiperOrigin-RevId: 515024483 Change-Id: Ic8097979d06ab143b4d63f5e90f871f8cbf83959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual file prefetches within a single prefetchFiles() can race against each other, so they must synchronize when writing to the DirectoryContext.