Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0]Fix RPATHs for cc toolchain solib when sibling layout is used #17506

Merged
merged 3 commits into from
Feb 17, 2023
Merged

[6.1.0]Fix RPATHs for cc toolchain solib when sibling layout is used #17506

merged 3 commits into from
Feb 17, 2023

Conversation

yuzhy8701
Copy link
Contributor

@yuzhy8701 yuzhy8701 commented Feb 15, 2023

Fixes #16956

Includes the following changes:

  • Refactor logics to find runtime library search directories
  • Correctly compute RPATHs for toolchain solib.

Closes #17276.

PiperOrigin-RevId: 509815187
Change-Id: I7f2a2412aea6430fa712dd2836e18f9536757753
(cherry picked from commit 773d232)

This should fix issue #16956

Includes the following changes:

- Refactor logics to find runtime library search directories
- Correctly compute RPATHs for toolchain solib.

Closes #17276.

PiperOrigin-RevId: 509815187
Change-Id: I7f2a2412aea6430fa712dd2836e18f9536757753
(cherry picked from commit 773d232)
@yuzhy8701 yuzhy8701 changed the title Fix RPATHs for cc toolchain solib when sibling layout is used [6.1.0] Fix RPATHs for cc toolchain solib when sibling layout is used Feb 15, 2023
@yuzhy8701 yuzhy8701 changed the title [6.1.0] Fix RPATHs for cc toolchain solib when sibling layout is used [6.1.0]Fix RPATHs for cc toolchain solib when sibling layout is used Feb 15, 2023
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Feb 16, 2023
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 17, 2023
@ShreeM01 ShreeM01 merged commit ec36595 into bazelbuild:release-6.1.0 Feb 17, 2023
@keertk keertk removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants