Fix Java coverage collection with Java 8 runtime #17338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-java8-coverage
branch
from
7ea67a4
to
b34bd8c
Compare
`JacocoRunner` is run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime.
fmeum
force-pushed
the
fix-java8-coverage
branch
from
b34bd8c
to
bdf23de
Compare
fmeum
changed the title
|
I confirmed locally that the issue is fixed. Setting up an integration test for this would require JDK 8 to be available in CI, which as far as I can tell isn't available on most CI runners anymore. |
|
@cushon Could you review? |
|
This makes sense to me. I'm not sure how owns this stuff, @comius is there anyone you want to loop in for this? |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
ShreeM01
added
team-Rules-Java
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
comius
approved these changes
Feb 7, 2023
|
LGTM from my side, but WANT_LGTM=c-mita also |
|
@c-mita just in case |
c-mita
approved these changes
Feb 7, 2023
hvadehra
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
ShreeM01
added a commit
that referenced
this pull request
Feb 15, 2023
`JacocoCoverageRunner` is run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime. Fixes #17165 Closes #17338. PiperOrigin-RevId: 509123073 Change-Id: I41d7255e1f3c3dd3864082899d5dc9ab2cc82027 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JacocoCoverageRunneris run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime.Fixes #17165