Do the AC integrity check for disk part of the combined cache. #17201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
coeuvre
added
the
team-Remote-Exec
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
the
awaiting-review
ShreeM01
added a commit
that referenced
this pull request
Jan 25, 2023
This will decrease the cache-hit rate for disk cache when building without the bytes. See #17080 for reasoning. With lease service, the decrement will be fixed. Fixes #17080. Closes #17201. PiperOrigin-RevId: 502818641 Change-Id: I1f73dd38d7e52e2f39b367e6114aab714de22d3c Co-authored-by: Chi Wang <chiwang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will decrease the cache-hit rate for disk cache when building without the bytes. See #17080 for reasoning.
With lease service, the decrement will be fixed.
Fixes #17080.