Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for concurrent modifications #17174

Closed
wants to merge 2 commits into from
Closed

Improve error message for concurrent modifications #17174

wants to merge 2 commits into from

Conversation

tbaing
Copy link
Contributor

@tbaing tbaing commented Jan 9, 2023

Improve the error message logged when concurrent modifications
occur and --experimental_guard_against_concurrent_changes is set.

tbaing and others added 2 commits January 9, 2023 18:53
@tbaing
Improve error message for concurrent modifications
edaeb72 
Improve the error message logged when concurrent modifications
occur and --experimental_guard_against_concurrent_changes is set.
@tbaing
Merge branch 'bazelbuild:master' into 17173_improve_error_message
ce26897
@tbaing tbaing requested a review from a team as a code owner January 9, 2023 20:05
@ShreeM01 ShreeM01 added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2023
coeuvre
coeuvre approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 11, 2023
@coeuvre coeuvre mentioned this pull request Jan 12, 2023
Closed
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 12, 2023
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 18, 2023
@bazel-io bazel-io mentioned this pull request Jan 18, 2023
Closed
@ShreeM01 ShreeM01 mentioned this pull request Jan 25, 2023
Closed
@ShreeM01
Copy link
Contributor

ShreeM01 commented Jan 26, 2023 •
edited
Loading

Hi @tbaing! To avoid presubmit fail #17323 Could you please sign the CLA with the Email you used? https://github.com/bazelbuild/bazel/pull/17323/checks?check_run_id=10886732089 Thanks!

hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@tbaing @hvadehra
Improve error message for concurrent modifications
78d4be9 
Improve the error message logged when concurrent modifications
occur and --experimental_guard_against_concurrent_changes is set.

Closes #17174.

PiperOrigin-RevId: 501012999
Change-Id: Id661ff2e5f98173323ebecb75b5e9825c8e0491e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbaing @brentleyjones @ShreeM01 @coeuvre @bazel-io @sgowroji