Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Mention layering_check in header inclusion check docs #17057

Closed
wants to merge 1 commit into from
Closed

docs: Mention layering_check in header inclusion check docs #17057

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 20, 2022

The layering_check feature and toolchain support are required to realize header dependency checking in Bazel. If enabled, this also reports errors for explicitly included transitive, non-direct headers.

Fixes #17055
Fixes #15632

@fmeum
docs: Mention layering_check in header inclusion check docs
b1e7337 
The `layering_check` feature and toolchain support are required to
realize header dependency checking in Bazel. If enabled, this also
reports errors for explicitly included transitive, non-direct headers.
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 20, 2022

@oquenchil Could you verify that what I wrote (and deleted) is actually correct? I have seen layering_check work on macOS, but that might have been with the non-Xcode toolchain. If the Xcode toolchain doesn't support layering_check, I would update the docs to reflect that (or try to add support).

@fmeum fmeum mentioned this pull request Dec 20, 2022
Closed
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 20, 2022
@oquenchil
Copy link
Contributor

Yes, this is correct, @hlopko added support for this a couple of years ago.

@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 20, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 3, 2023

@oquenchil @sgowroji Friendly ping, does this still need to be imported?

@copybara-service copybara-service bot closed this in 90eee43 Jan 3, 2023
@sgowroji
Copy link
Member

sgowroji commented Jan 3, 2023

Its imported at 90eee43

@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 3, 2023
@fmeum fmeum deleted the 17055-layering-check-docs branch January 3, 2023 14:27
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@fmeum @hvadehra
docs: Mention layering_check in header inclusion check docs
a1db6fe 
The `layering_check` feature and toolchain support are required to realize header dependency checking in Bazel. If enabled, this also reports errors for explicitly included transitive, non-direct headers.

Fixes #17055
Fixes #15632

Closes #17057.

PiperOrigin-RevId: 499189567
Change-Id: Ia7978193e4572a358e26d24183d125649f8654b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
3 participants
@fmeum @oquenchil @sgowroji