Also collect clang resource directory with -no-canonical-prefixes
#16730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-print-resource-dir
branch
from
3bdb5b0
to
afa197f
Compare
`clang -print-resource-dir` without `-no-canonical-prefixes` returns a different path than is actually used to include `asan_blacklist.txt` on macOS.
fmeum
force-pushed
the
fix-print-resource-dir
branch
from
afa197f
to
fcd8863
Compare
fmeum
changed the title
-no-canonical-prefixes
|
@oquenchil Could you review this small fix? I have a very hard time reproducing this on the Bazel CI runners, so this doesn't come with a test. It shows up with Homebrew LLVM on GitHub Actions runners and without GNU readlink in path, which means that the |
sgowroji
added
team-Rules-CPP
keith
approved these changes
Nov 10, 2022
oquenchil
approved these changes
Nov 15, 2022
oquenchil
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 18, 2022
`clang -print-resource-dir` without `-no-canonical-prefixes` returns a different path than is actually used to include `asan_blacklist.txt` on macOS with non-Apple clang. Closes bazelbuild#16730. PiperOrigin-RevId: 489475662 Change-Id: If17f347d76f86e0ec5804f9e8789f44f46ab27b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang -print-resource-dirwithout-no-canonical-prefixesreturns a different path than is actually used to includeasan_blacklist.txton macOS with non-Apple clang.