Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only try to create groups of test actions in the ui. #16176

Closed
wants to merge 1 commit into from
Closed

Only try to create groups of test actions in the ui. #16176

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

A target with test actions may have other actions registered that should not be reported in the UI as tests themselves.

Fixes #16174.

@benjaminp
Only try to create groups of test actions in the ui.
85b56b5 
A target with test actions may have other actions registered that should not be reported in the UI as tests themselves.

Fixes bazelbuild#16174.
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Aug 29, 2022
@oquenchil oquenchil self-assigned this Dec 16, 2022
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 23, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 23, 2023
@benjaminp benjaminp deleted the only-aggregating-test-actions branch January 23, 2023 14:07
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this pull request Jan 25, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 25, 2023
@ShreeM01 ShreeM01 mentioned this pull request Jan 26, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 27, 2023
@ShreeM01 @benjaminp
Only try to create groups of test actions in the ui. (#17343)
625128c 
A target with test actions may have other actions registered that should not be reported in the UI as tests themselves.

Fixes #16174.

Closes #16176.

PiperOrigin-RevId: 503961303
Change-Id: I7df82a6f7c01532cd8f2feac50078daf599fc56a

Co-authored-by: Benjamin Peterson <benjamin@engflow.com>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@benjaminp @hvadehra
Only try to create groups of test actions in the ui.
f12022c 
A target with test actions may have other actions registered that should not be reported in the UI as tests themselves.

Fixes #16174.

Closes #16176.

PiperOrigin-RevId: 503961303
Change-Id: I7df82a6f7c01532cd8f2feac50078daf599fc56a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees

@oquenchil oquenchil

Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undesired output behavior for cc_test srcs
6 participants
@benjaminp @brentleyjones @ShreeM01 @oquenchil @bazel-io @sgowroji