-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail the build on repository rule errors in a module extension #15796
Conversation
e1bf4a4
to
eac799d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
@bazel-io flag |
@bazel-io fork 5.3.0 |
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment)
eac799d
to
7db6ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Hey @fmeum , we are trying to cherry-pick these changes to release-5.3.0. But pre-submit checks are failing due to missing dependencies. So, could you please help us in cherry picking these changes to release-5.3.0? |
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Fail the build on repository rule errors in a module extension
Also emit a Starlark stack trace pointing to the particular call site
of the repository rule.
Previously, the root cause error would be printed, but the build would
continue.
Fixes #14526 (comment)