Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunker: Always seek on the uncompressed stream. #15669

Closed
wants to merge 1 commit into from
Closed

Chunker: Always seek on the uncompressed stream. #15669

wants to merge 1 commit into from

Commits on Jun 13, 2022

  1. Chunker: Always seek on the uncompressed stream. 

    The `WriteRequest.write_offset` field has bizarre semantics during compressed uploads as documented in the remote API protos: https://github.com/bazelbuild/remote-apis/blob/3b4b6402103539d66fcdd1a4d945f660742665ca/build/bazel/remote/execution/v2/remote_execution.proto#L241-L248 In particular, the write offset of the first `WriteRequest` refers to the offset in the uncompressed source.

This change ensures we always seek the uncompressed stream to the correct offset when starting an upload call. The old code could fail to resume compressed uploads under some conditions. The `progressiveCompressedUploadShouldWork` test purported to exercise this situation. The test, however, contained the same logic error as the code under test.
    @benjaminp
    benjaminp committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    29f822e View commit details
    Browse the repository at this point in the history