Implement --remote_force_print_messages #15557
Conversation
sgowroji
added
team-Remote-Exec
| @@ -574,6 +574,17 @@ public RemoteOutputsStrategyConverter() { | |||
| help = "Maximum number of open files allowed during BEP artifact upload.") | |||
| public int maximumOpenFiles; | |||
|
|
|||
| @Option( | |||
| name = "remote_force_print_messages", | |||
There was a problem hiding this comment.
maybe change to remote_always_print_execution_message?
There was a problem hiding this comment.
Changed to remote_print_execution_messages with changing it to be a tristate flag
|
IIUC, you are suggesting treating the execution message as warning from the rule which owns the spawn? I think they are different things. For example, the execution message can be sent to Bazel for all spawns that come from different rules, but you probably don't want see warnings from those rules. |
|
Alright, after an offline discussion with @coeuvre, I agree that we should treat the execution message as distinct from the action stdout/stderr. Separate comment: is there already a flag to silence all execution messages? If not, should we make this option a tristate |
Adds a flag for controlling when to print messages from remotely executed actions.
exoson
force-pushed
the
dev/force_messages
branch
from
86de593 to
7a0ef3b
Compare
ShreeM01
removed
the
awaiting-review
Adds a flag for always printing messages returned by remotely executed
actions.