Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CC_CODE_COVERAGE_SCRIPT failures fail tests #15420

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make CC_CODE_COVERAGE_SCRIPT failures fail tests #15420

wants to merge 5 commits into from

Conversation

keith
Copy link
Member

@keith keith commented May 9, 2022

If you're editing, or overriding, this script and you introduce and
introduce an error, previously this wouldn't fail the test invocation.

@keith keith requested a review from lberki as a code owner May 9, 2022 02:44
@sgowroji sgowroji added team-Rules-Server Issues for serverside rules included with Bazel awaiting-user-response Awaiting a response from the author labels May 9, 2022
@lberki lberki requested review from c-mita and removed request for lberki May 9, 2022 06:56
@keith keith mentioned this pull request May 21, 2022
Merged
@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Aug 11, 2022
@comius comius added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 26, 2022
@comius
Copy link
Contributor

comius commented Aug 26, 2022

there are CI failures

@keertk
Copy link
Member

keertk commented Dec 7, 2022

Hi there! Thank you for contributing to the Bazel repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@keertk keertk closed this Dec 7, 2022
@keith
Copy link
Member Author

keith commented Dec 7, 2022

@keertk can you reopen please

@keertk keertk reopened this Dec 7, 2022
@keith keith force-pushed the ks/make-cc_code_coverage_script-failures-fail-tests branch from 575b63f to 9a0b847 Compare January 10, 2023 01:23
@keith keith mentioned this pull request Aug 4, 2023
Open
@keith keith marked this pull request as draft August 4, 2023 16:43
@comius
Copy link
Contributor

comius commented Sep 25, 2023

Closing as another 2 months passed by. Feel free to reopen.

@comius comius closed this Sep 25, 2023
@keith
Copy link
Member Author

keith commented Oct 23, 2023

we should really do this but fixing the existing tests is definitely annoying

@keith keith reopened this Jan 9, 2024
@keith keith force-pushed the ks/make-cc_code_coverage_script-failures-fail-tests branch from 9a0b847 to 8313587 Compare January 9, 2024 18:03
@keith
Copy link
Member Author

keith commented Jan 9, 2024

reopening with a opt-in env var to continue ignoring this failure meant only to avoid all the issues with bazel tests + CI setup (users should avoid this flag)

@keith keith marked this pull request as ready for review January 10, 2024 17:42
@keith keith requested a review from a team as a code owner January 10, 2024 17:42
@keith
Copy link
Member Author

keith commented Jan 10, 2024

@comius what do you think about this solution to avoid having to fix all the tests + CI runner setup

@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2024
@keith
Copy link
Member Author

keith commented Jan 22, 2024

@comius can you take a look?

@keith
Copy link
Member Author

keith commented Feb 16, 2024

@comius can you take a look?

@keith keith removed the awaiting-user-response Awaiting a response from the author label Feb 29, 2024
@keith
Copy link
Member Author

keith commented May 16, 2024

@comius friendly ping

@comius
Copy link
Contributor

comius commented May 17, 2024

ping @c-mita

@keith
Copy link
Member Author

keith commented Jun 4, 2024

@c-mita can you take a look?

keith added 4 commits January 13, 2025 14:55
@keith
Make CC_CODE_COVERAGE_SCRIPT failures fail tests
d3901c6 
If you're editing, or overriding, this script and you introduce and
introduce an error, previously this wouldn't fail the test invocation.
@keith
Test fix
f76cd09
@keith
more fixes
849c1df
@keith
more exclusions
3dad2a9
@keith keith force-pushed the ks/make-cc_code_coverage_script-failures-fail-tests branch from ab3967d to 3dad2a9 Compare January 13, 2025 22:56
@keith
Copy link
Member Author

keith commented Jan 14, 2025

@c-mita @comius ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita Awaiting requested review from c-mita

Assignees

@c-mita c-mita

Labels
awaiting-review PR is awaiting review from an assigned reviewer coverage team-Remote-Exec Issues and PRs for the Execution (Remote) team team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keith @comius @keertk @c-mita @sgowroji