Make coverage --combined_report=lcov skip incompatible tests
#15419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch we see coverage trying to execute incompatible tests. This results in `Can't build this. This target is incompatible` messages. Instead, those tests should just be skipped. This patch makes it so the coverage code only tries to collect coverage artifacts for compatible tests. Artifacts for incompatible tests are ignored.
sgowroji
added
team-Rules-CPP
c-mita
added
coverage
and removed
awaiting-review
philsc
added a commit
to philsc/bazel
that referenced
this pull request
May 12, 2022
Before this patch we see coverage trying to execute incompatible tests. This results in `Can't build this. This target is incompatible` messages. Instead, those tests should just be skipped. This patch makes it so the coverage code only tries to collect coverage artifacts for compatible tests. Artifacts for incompatible tests are ignored. Fixes bazelbuild#15385 Closes bazelbuild#15419. PiperOrigin-RevId: 447710011 (cherry picked from commit 2f1ff6f)
philsc
added a commit
to philsc/bazel
that referenced
this pull request
May 18, 2022
Before this patch we see coverage trying to execute incompatible tests. This results in `Can't build this. This target is incompatible` messages. Instead, those tests should just be skipped. This patch makes it so the coverage code only tries to collect coverage artifacts for compatible tests. Artifacts for incompatible tests are ignored. Fixes bazelbuild#15385 Closes bazelbuild#15419. PiperOrigin-RevId: 447710011 (cherry picked from commit 2f1ff6f)
ckolli5
added a commit
that referenced
this pull request
May 19, 2022
Before this patch we see coverage trying to execute incompatible tests. This results in `Can't build this. This target is incompatible` messages. Instead, those tests should just be skipped. This patch makes it so the coverage code only tries to collect coverage artifacts for compatible tests. Artifacts for incompatible tests are ignored. Fixes #15385 Closes #15419. PiperOrigin-RevId: 447710011 (cherry picked from commit 2f1ff6f) Co-authored-by: Chenchu Kolli <ckolli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we see coverage trying to execute incompatible
tests. This results in
Can't build this. This target is incompatiblemessages. Instead, those tests should just be skipped.
This patch makes it so the coverage code only tries to collect
coverage artifacts for compatible tests. Artifacts for incompatible
tests are ignored.
Fixes #15385