Fixing dependencies of //external package #15341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to query `kind('source file', deps(//external:*))` for sparse checkout, but were block by two issues:
* `//external:remotejdk11_linux` depends on `tools/jdk/jdk.BUILD`, but it was not exported. Although this is not a problem for build, queries like `kind('source file', deps(//external:remotejdk11_linux))` would fail.
* `//external:android_sdk_for_testing` is an alias for `//:dummy`, which is not available in other repositories. This also caused bazelbuild#8175.
This pull request fixed both, including bazelbuild#8175.
Closes bazelbuild#15134.
PiperOrigin-RevId: 438605051
sgowroji
added
team-Android
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to query
kind('source file', deps(//external:*))for sparse checkout, but were block by two issues://external:remotejdk11_linuxdepends ontools/jdk/jdk.BUILD, but it was not exported. Although this is not a problem for build, queries likekind('source file', deps(//external:remotejdk11_linux))would fail.//external:android_sdk_for_testingis an alias for//:dummy, which is not available in other repositories. This also caused bazel query rdeps fails in//externalbecause//:dummytarget doesn't exist #8175.This pull request fixed both, including #8175.
This cherry-picks dbb6e99 into release-5.2.0
PiperOrigin-RevId: 438605051