Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote: Proactively close the ZstdInputStream in ZstdDecompressingOutputStream. #15061

Closed
wants to merge 1 commit into from
Closed

remote: Proactively close the ZstdInputStream in ZstdDecompressingOutputStream. #15061

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.

@benjaminp benjaminp requested a review from a team as a code owner March 17, 2022 02:31
@benjaminp benjaminp force-pushed the remote-close branch 10 times, most recently from 4be55d2 to 1728fa6 Compare March 17, 2022 05:32
@benjaminp
remote: Proactively close the ZstdInputStream in ZstdDecompressingOut…
9671af0 
…putStream.

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.
@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Mar 17, 2022
coeuvre
coeuvre approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in 299022c Mar 31, 2022
@brentleyjones
Copy link
Contributor

@bazel-io fork 5.2

@bazel-io bazel-io mentioned this pull request Mar 31, 2022
Closed
@benjaminp benjaminp deleted the remote-close branch April 5, 2022 05:02
@ckolli5 ckolli5 mentioned this pull request Apr 29, 2022
Merged
ckolli5 added a commit that referenced this pull request May 2, 2022
@ckolli5 @benjaminp
remote: Proactively close the ZstdInputStream in ZstdDecompressingOut…
0fb60cd 
…putStream. (#15372)

ZstdInputStream hangs onto some native memory, which should be released as soon as ZstdDecompressingOutputStream is done being used rather than when the finalizer runs.

Closes #15061.

PiperOrigin-RevId: 438521302

Co-authored-by: Benjamin Peterson <benjamin@engflow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminp @brentleyjones @coeuvre @sgowroji