Run tests in runfiles directory without LCOV_MERGER
#15030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`collect_coverage.sh` has the execution root as it's working directory, but tests should still be run from their runfiles directory if `LCOV_MERGER` is missing.
keith
added a commit
to keith/bazel
that referenced
this pull request
Mar 12, 2022
As discovered in bazelbuild#15030 there was another bug with the short circuiting coverage logic where tests were not run from the correct directory. In that PR this issue is fixed directly, with this change we instead make missing LCOV_MERGER be deferred until after all test setup and run, which I think is more future proof to other changes here, and also allows users to know their tests are being run with coverage, and output the correct files, even in the case they don't setup the coverage merger infrastructure.
|
Thanks for submitting this! Seeing another issue with this setup code I submitted this alternative that I think would be more future proof, but it's up to @c-mita to decide on which approach makes sense. Can you add a test similar to the runfiles tests I added in my PR to catch regressions in the case @c-mita wants to go with this change? |
keith
added a commit
to keith/bazel
that referenced
this pull request
Mar 12, 2022
As discovered in bazelbuild#15030 there was another bug with the short circuiting coverage logic where tests were not run from the correct directory. In that PR this issue is fixed directly, with this change we instead make missing LCOV_MERGER be deferred until after all test setup and run, which I think is more future proof to other changes here, and also allows users to know their tests are being run with coverage, and output the correct files, even in the case they don't setup the coverage merger infrastructure.
|
I also think that the approach of #15031 is more future-proof. I can't edit the PR at the moment, but will do so in case the other PR can't be used for some reason. |
|
I think @keith's approach is better here; deferring the |
bazel-io
pushed a commit
that referenced
this pull request
Mar 15, 2022
As discovered in #15030 there was another bug with the short circuiting coverage logic where tests were not run from the correct directory. In that PR this issue is fixed directly, with this change we instead make missing LCOV_MERGER be deferred until after all test setup and run, which I think is more future proof to other changes here, and also allows users to know their tests are being run with coverage, and output the correct files, even in the case they don't setup the coverage merger infrastructure. Closes #15031. PiperOrigin-RevId: 434715347
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Mar 15, 2022
As discovered in bazelbuild#15030 there was another bug with the short circuiting coverage logic where tests were not run from the correct directory. In that PR this issue is fixed directly, with this change we instead make missing LCOV_MERGER be deferred until after all test setup and run, which I think is more future proof to other changes here, and also allows users to know their tests are being run with coverage, and output the correct files, even in the case they don't setup the coverage merger infrastructure. Closes bazelbuild#15031. PiperOrigin-RevId: 434715347
Wyverald
pushed a commit
that referenced
this pull request
Mar 15, 2022
As discovered in #15030 there was another bug with the short circuiting coverage logic where tests were not run from the correct directory. In that PR this issue is fixed directly, with this change we instead make missing LCOV_MERGER be deferred until after all test setup and run, which I think is more future proof to other changes here, and also allows users to know their tests are being run with coverage, and output the correct files, even in the case they don't setup the coverage merger infrastructure. Closes #15031. PiperOrigin-RevId: 434715347 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collect_coverage.shhas the execution root as it's working directory, but tests should still be run from their runfiles directory ifLCOV_MERGERis missing.