Create mini_tar and switch to it for our blackbox tests. #14935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiuto
changed the title
aiuto
requested review from
oquenchil and
meteorcloudy
and removed request for
oquenchil
Is it possible to move mini_tar as a data dependency of the test instead of still shipping it in |
|
I can do that. But it's going to take some time to detangle the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@bazel_tools/build_defs/pkg/tar.bzl%mini_tar.This is limited functionality tar file builder. Its purpose is mainly for building tar files inside tests, where we do not want to take a dependency on the external repository @rules_pkg.
This means bazel itself does not depend on tools/build_defs/pkg/pkg.bzl at all any more, so we are free to delete that as soon as we have migrated the last of the users away.
Advances #11183