Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix bazel coverage false negative #14836

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[5.1] Fix bazel coverage false negative #14836

merged 1 commit into from
Feb 16, 2022

Commits on Feb 16, 2022

  1. Fix bazel coverage false negative 

    Previously this short circuit meant the tests weren't actually run, and
they would always exit 0, in the case the test rule didn't set the lcov
related attributes.

More context: bazelbuild#13978

Closes bazelbuild#14807.

RELNOTES: Fixed an issue where Bazel could erroneously report a test passes in coverage mode without actually running the test.
PiperOrigin-RevId: 428756211
(cherry picked from commit 16de035)
    @keith @brentleyjones
    keith authored and brentleyjones committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d53c0a1 View commit details
    Browse the repository at this point in the history