Update turbine #14059
Closed
Update turbine #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I had to revert this (and should have waited for the presubmit tests to complete...), because it breaks some tests: https://buildkite.com/bazel/bazel-bazel/builds/17471 |
|
Sorry about that, and thanks for taking care of the rollback. I think this has exposed an issue with those tests, I mailed cl/399718766 to prepare them for this change. |
|
The CI is passing with the pending change to |
bazel-io
pushed a commit
that referenced
this pull request
Sep 29, 2021
e.g. for ` //src/test/shell/bazel:bazel_java_test_jdk16_toolchain_head`, this test was previously using `@bazel_tools//tools/jdk:toolchain`, which was leaking the toolchain from the enclosing version of Bazel. It worked anyways because turbine was always producing JDK 8 class files, but as of google/turbine@006a74b turbine uses the class file version corresponding to the `-target` or `--release` flag. This fixes e.g. ``` java/com/google/sandwich/B.java:3: error: cannot access C C myObject; ^ bad class file: bazel-out/k8-fastbuild/bin/java/com/google/sandwich/libbottom-hjar.jar(/com/google/sandwich/C.class) class file has wrong version 59.0, should be 55.0 Please remove or make sure it appears in the correct subdirectory of the classpath. ``` from #14059 PiperOrigin-RevId: 399738050
Closed
comius
approved these changes
Oct 4, 2021
|
@philwo This PR is ready for a manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google/turbine@cb60060
#13965