Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of java allocation instrumenter. #13728

Closed
wants to merge 3 commits into from
Closed

Bump version of java allocation instrumenter. #13728

wants to merge 3 commits into from

Conversation

meisterT
Copy link
Member

Part of #13726.

@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@meisterT meisterT requested a review from meteorcloudy July 22, 2021 08:06
@meteorcloudy
Copy link
Member

One test on macOS is broken:

test_size_less_than_295MB FAILED: Size of install_base is 310112 kB, expected it to be less than 302080 kB..
/private/var/tmp/_bazel_buildkite/d30584ef0665575526506875aa4ad22e/sandbox/darwin-sandbox/3922/execroot/io_bazel/bazel-out/darwin-fastbuild/bin/src/test/shell/integration/minimal_jdk_test.runfiles/io_bazel/src/test/shell/integration/minimal_jdk_test:55: in call to test_size_less_than_295MB
INFO[minimal_jdk_test 2021-07-22 08:16:33 (+0000)] Cleaning up workspace

bazel-io pushed a commit that referenced this pull request Jul 22, 2021
@meisterT @copybara-github
Increase allowed size of the install_base.
951a302 
This is in preparation of importing #13728 which increases the size the of jar file by 2MB.

PiperOrigin-RevId: 386191612
@meteorcloudy
Copy link
Member

meteorcloudy commented Jul 22, 2021 •
edited
Loading

Almost there 😂:
test_size_less_than_300MB FAILED: Size of install_base is 310280 kB, expected it to be less than 307200 kB

bazel-io pushed a commit that referenced this pull request Jul 23, 2021
@meisterT @meteorcloudy
Bump version of java allocation instrumenter.
affc27f 
Part of #13726.

Partial commit for third_party/*, see #13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
@meteorcloudy
Copy link
Member

Merged at affc27f

meisterT added a commit to meisterT/bazel that referenced this pull request Jul 23, 2021
@meisterT
Increase allowed size of the install_base.
25acf31 
This is in preparation of importing bazelbuild#13728 which increases the size the of jar file by 2MB.

PiperOrigin-RevId: 386191612
meisterT added a commit to meisterT/bazel that referenced this pull request Jul 23, 2021
@meisterT
Bump version of java allocation instrumenter.
8769a16 
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
katre pushed a commit to meisterT/bazel that referenced this pull request Jul 23, 2021
@meisterT @katre
Increase allowed size of the install_base.
5fec280 
This is in preparation of importing bazelbuild#13728 which increases the size the of jar file by 2MB.

PiperOrigin-RevId: 386191612
katre pushed a commit to meisterT/bazel that referenced this pull request Jul 23, 2021
@meisterT @katre
Bump version of java allocation instrumenter.
1f1ac84 
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
meisterT added a commit to meisterT/bazel that referenced this pull request Jul 26, 2021
@meisterT
Increase allowed size of the install_base.
c9d2677 
This is in preparation of importing bazelbuild#13728 which increases the size the of jar file by 2MB.

PiperOrigin-RevId: 386191612
meisterT added a commit to meisterT/bazel that referenced this pull request Jul 26, 2021
@meisterT
Bump version of java allocation instrumenter.
16e91d3 
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meisterT @meteorcloudy