Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And mnemonic and label to remote metadata #13109

Closed

Conversation

illicitonion
Copy link
Contributor

@google-cla google-cla bot added the cla: yes label Feb 25, 2021
@coeuvre coeuvre self-requested a review February 26, 2021 04:27
@coeuvre coeuvre added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Feb 26, 2021
@coeuvre
Copy link
Member

coeuvre commented Feb 26, 2021

Thanks for the PR!

For reasons, we cannot merge a PR containing both third_party and non-third_party changes. Can you please split this into two PRs? (One for updating REAPI and another one for adding additional metadata)

@illicitonion
Copy link
Contributor Author

I split off #13133 for just the proto change, now that it's merged upstream :) Thanks!

@EdSchouten
Copy link
Contributor

Cc @coeuvre @philwo

Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13133 is merged. Please rebase and I will merge this.

@illicitonion
Copy link
Contributor Author

Rebased :) Thanks!

ulfjack added a commit to EngFlow/bazel that referenced this pull request Mar 5, 2021
This is a partial application of a pending pull request against Bazel
HEAD:
bazelbuild#13109

Unfortunately, the PR does not apply to Bazel 3.7 at all due to
extensive changes in how metadata is propagated through the remote
execution stack.

Change-Id: I99e98f32fd460df03fb57838e2a7327646a22940
ulfjack added a commit to EngFlow/bazel that referenced this pull request Mar 5, 2021
This is a partial application of a pending pull request against Bazel
HEAD:
bazelbuild#13109

Unfortunately, the PR does not apply to Bazel 3.7 at all due to
extensive changes in how metadata is propagated through the remote
execution stack.

Change-Id: I99e98f32fd460df03fb57838e2a7327646a22940
@coeuvre
Copy link
Member

coeuvre commented Mar 11, 2021

Waiting for bazelbuild/remote-apis#186 to be imported. Once that's done, this should be merged automatically.

@philwo
Copy link
Member

philwo commented Mar 12, 2021

@coeuvre It seems like the linked change was already merged:

image

Is there something left to do?

@coeuvre
Copy link
Member

coeuvre commented Mar 15, 2021

Yes. We use internal version of REAPI internally. The linked change need to be imported to the internal REAPI first so we can import this change. (b/182107620)

@EdSchouten
Copy link
Contributor

(Friendly ping :-) )

@bazel-io bazel-io closed this in a750a56 Apr 16, 2021
philwo pushed a commit that referenced this pull request Apr 20, 2021
This reflects bazelbuild/remote-apis#186

Closes #13109.

PiperOrigin-RevId: 368763391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants