Implement getMessage for BulkTransferException #13061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, BulkTransferExceptions would be reported like this:
Executing genrule //:foo failed: Exec failed due to IOException: null
By implementing getMessage(), we get a more informative message, in the case
when there is only one suppressed exception:
Executing genrule //:foo failed: Exec failed due to IOException:
Output download failed: Expected digest
'8a39d2abd3999ab73c34db2476849cddf303ce389b35826850f9a700589b4a90/262144'
does not match received digest
'dae4d3dce1bb0a9414f61a65ee07622fa225ec01e6efe6df6e78f9ad5c58480d/327680'.
and in the case when there are multiple suppressed exceptions:
Executing genrule //:foo failed: Exec failed due to IOException:
2 errors during bulk transfer
This helps diagnosing issues like bazelbuild#12927
|
Looks like RE code; I'll defer to @coeuvre to look at this. |
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
Before this change, BulkTransferExceptions would be reported like this:
```
Executing genrule //:foo failed: Exec failed due to IOException: null
```
By implementing getMessage(), we get a more informative message, in the case
when there is only one suppressed exception:
```
Executing genrule //:foo failed: Exec failed due to IOException:
Output download failed: Expected digest '8a39d2abd3999ab73c34db2476849cddf303ce389b35826850f9a700589b4a90/262144'
does not match received digest 'dae4d3dce1bb0a9414f61a65ee07622fa225ec01e6efe6df6e78f9ad5c58480d/327680'.
```
and in the case when there are multiple suppressed exceptions:
```
Executing genrule //:foo failed: Exec failed due to IOException:
2 errors during bulk transfer
```
This helps diagnosing issues like #12927
Closes #13061.
PiperOrigin-RevId: 359250576
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
Before this change, BulkTransferExceptions would be reported like this:
```
Executing genrule //:foo failed: Exec failed due to IOException: null
```
By implementing getMessage(), we get a more informative message, in the case
when there is only one suppressed exception:
```
Executing genrule //:foo failed: Exec failed due to IOException:
Output download failed: Expected digest '8a39d2abd3999ab73c34db2476849cddf303ce389b35826850f9a700589b4a90/262144'
does not match received digest 'dae4d3dce1bb0a9414f61a65ee07622fa225ec01e6efe6df6e78f9ad5c58480d/327680'.
```
and in the case when there are multiple suppressed exceptions:
```
Executing genrule //:foo failed: Exec failed due to IOException:
2 errors during bulk transfer
```
This helps diagnosing issues like #12927
Closes #13061.
PiperOrigin-RevId: 359250576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, BulkTransferExceptions would be reported like this:
By implementing getMessage(), we get a more informative message, in the case
when there is only one suppressed exception:
and in the case when there are multiple suppressed exceptions:
This helps diagnosing issues like #12927