Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jar Class-Path url encoding in java_stub_template #12946

Closed
wants to merge 2 commits into from
Closed

Fix jar Class-Path url encoding in java_stub_template #12946

wants to merge 2 commits into from

Conversation

Bencodes
Copy link
Contributor

@Bencodes Bencodes commented Feb 2, 2021 •
edited
Loading

This recently got patched in the native launcher here but it wasn't ported over to java_stub_template.txt. The original issue for this is #10620

@google-cla google-cla bot added the cla: yes label Feb 2, 2021
@Bencodes Bencodes force-pushed the fix-class-path-url-encoding-in-java_stub_template branch from d9654fb to 045788f Compare February 2, 2021 17:06
@Bencodes Bencodes mentioned this pull request Feb 3, 2021
Closed
@meteorcloudy meteorcloudy requested a review from mai93 February 4, 2021 12:39
@mai93
Copy link
Contributor

mai93 commented Feb 5, 2021

Thank you, @Bencodes. I created a new PR #12969 to fix this for other special characters.

@Bencodes Bencodes closed this Feb 7, 2021
@Bencodes Bencodes deleted the fix-class-path-url-encoding-in-java_stub_template branch February 7, 2021 01:28
@Bencodes Bencodes mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@mai93 mai93 Awaiting requested review from mai93

Assignees

@meteorcloudy meteorcloudy

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bencodes @mai93 @meteorcloudy