Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update threshold for long path shortening to be MAX_PATH - 4 #12941

Closed
wants to merge 1 commit into from
Closed

Update threshold for long path shortening to be MAX_PATH - 4 #12941

wants to merge 1 commit into from

Conversation

mai93
Copy link
Contributor

@mai93 mai93 commented Feb 1, 2021

This PR applies the suggested fix for #12310. Although I could not reproduce it.

Fixes: #12310

@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@mai93 mai93 changed the title Update threshold for long path shortening to be 158 not 160 Update threshold for long path shortening to be MAX_PATH -2 Feb 2, 2021
@meteorcloudy meteorcloudy mentioned this pull request Feb 2, 2021
Closed
@jin jin added area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Mar 1, 2021
meteorcloudy
meteorcloudy approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We still don't have a reproduce case without RBE? Otherwise, adding a test would be a good idea.

@mai93 mai93 changed the title Update threshold for long path shortening to be MAX_PATH -2 Update threshold for long path shortening to be MAX_PATH - 4 Mar 11, 2021
@mai93
Copy link
Contributor Author

mai93 commented Mar 11, 2021

Yes, I could not reproduce it without RBE.

@mai93 mai93 marked this pull request as ready for review March 11, 2021 15:45
meteorcloudy
meteorcloudy approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming, let's import this!

@bazel-io bazel-io closed this in 42e05db Mar 11, 2021
katre pushed a commit that referenced this pull request Jul 12, 2021
@mai93 @katre
Update threshold for long path shortening to be MAX_PATH - 4
00a799e 
This PR applies the suggested fix for #12310. Although I could not reproduce it.

Fixes: #12310

Closes #12941.

PiperOrigin-RevId: 362327025
katre pushed a commit to katre/bazel that referenced this pull request Jul 13, 2021
@mai93 @katre
Update threshold for long path shortening to be MAX_PATH - 4
a5807e6 
This PR applies the suggested fix for bazelbuild#12310. Although I could not reproduce it.

Fixes: bazelbuild#12310

Closes bazelbuild#12941.

PiperOrigin-RevId: 362327025
katre pushed a commit to katre/bazel that referenced this pull request Jul 13, 2021
@mai93 @katre
Update threshold for long path shortening to be MAX_PATH - 4
451b296 
This PR applies the suggested fix for bazelbuild#12310. Although I could not reproduce it.

Fixes: bazelbuild#12310

Closes bazelbuild#12941.

PiperOrigin-RevId: 362327025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees

@meteorcloudy meteorcloudy

Labels
area-Windows Windows-specific issues and feature requests cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel+RBE failure on Windows with target of length 89 or 90
3 participants
@mai93 @meteorcloudy @jin