-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Java tests to use Java toolchain resolution. #12695
Conversation
63fc353
to
a0b5e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all of this code deleted, can users actually unset the flag? If someone needs to do "bazel build --noincompatible_use_toolchain_resolution_for_java_rules", will that work, or will it fail?
I will fail, I should remove the flag as well. |
That's the opposite of what I would prefer: we should only flip the flag in this release, wait a bazel release, and then remove the code. |
a0b5e93
to
d52230c
Compare
Ok. I reverted the removal and kept everything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very excited to see this!
I will delay flipping the flag a bit, because RBE would potentially break on downstream projects. I need to prepare couple of fixes in both bazel and bazel_toolchains. |
The flag is flipped for tests, old configuration options
javabase
andjava_toolchain
are marked deprecated. All the tests are fixed to execute using new toolchain resolution.Changed
local_java_repository
to generatejava_runtime
withjava_home
parameter set (instead of srcs). This behaves better, becausejava_stub_template.txt
then does not need runfiles to execute produceddeploy.jar
. Kept the same version withsrcs
in thejdk.WORKSPACE
.Fixes #4592.
Flips #7849.