Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ijar sources from deployment zip. #12556

Closed
wants to merge 4 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Nov 25, 2020

This is a github only patch from PR #12546. Needs to go in first.

@philwo
Copy link
Member

philwo commented Nov 25, 2020

@comius Can you check out the test failures?

@comius
Copy link
Contributor Author

comius commented Nov 25, 2020

@comius Can you check out the test failures?

Done, I love monorepos.

@bazel-io bazel-io closed this in de2dab0 Nov 25, 2020
bazel-io pushed a commit that referenced this pull request Nov 25, 2020
This is a github only patch from PR #12546. Needs to go in first.

PiperOrigin-RevId: 344260438
bazel-io pushed a commit that referenced this pull request Nov 27, 2020
…lt part.

This builds on top of the commit "Separate java_tools into platform independent and prebuilt part.".

- java_tools release 11.0 is used
- java_tools platform independent repo is added
- java toolchain definitions appropriate for new release are added to tools/jdk/BUILD
- remote_java_tools are replaced with aliases
- tests are reenabled

Changelog:
```
$ git log --pretty=format:"%h %an %s" cd3480e...5a91c25 -- src/java_tools/ third_party/ijar/ tools/jdk/BUILD.java_tools
d10013d Ivo List Separate java_tools into platform independent and prebuilt part.
3c9ad2d philwo Separate ijar sources from deployment zip. (#12556)
2d990cf philwo Fix #10127: Remove Python 2 dependency from tools/android.
de2dab0 Ivo List Separate ijar sources from deployment zip.
b17e9e4 Googler Automatic code cleanup.
```

Benchmark:
```
Bazel commit: /tmp/bazel-head, Project commit: c85ecbe, Project source: None
  metric          mean                median          stddev      pval
    wall:  185.647s             185.445s               2.224s
     cpu:   55.616s              54.410s               1.792s
  system:   18.043s              18.060s               0.330s
  memory:   94.000s              94.000s               0.000s

Bazel commit: /tmp/comius-bazel, Project commit: c85ecbe, Project source: None
  metric          mean                median          stddev      pval
    wall:  184.544s ( -0.59%)   184.456s ( -0.53%)     1.626s    0.03730
     cpu:   54.484s ( -2.03%)    54.990s ( +1.07%)     1.940s    0.42483
  system:   17.364s ( -3.76%)    17.260s ( -4.43%)     0.392s    0.94697
  memory:   94.000s ( +0.00%)    94.000s ( +0.00%)     0.000s    0.00000
```

Closes #12552.
Fixes #8406.

PiperOrigin-RevId: 344530341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants