Move getConfigConditions into ConfiguredTarget. #12550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a default value for non-alias and non-rule CTs. This alloows removing many instanceof/cast checks when getting config conditions. Part of the work on bazelbuild#11993.
juliexxia
approved these changes
Nov 24, 2020
| @@ -696,6 +696,7 @@ java_library( | |||
| name = "configured_target", | |||
| srcs = ["ConfiguredTarget.java"], | |||
| deps = [ | |||
| ":config/config_matching_provider", | |||
There was a problem hiding this comment.
This is totally orthogonal to your PR and just something I've never understood - why have a slash in a target name as opposed to just putting it under a directory called config?
There was a problem hiding this comment.
Because analysis_cluster contains files from inside the config subdirectory, config can't be its own package with its own BUILD file.
Ideally we'd further break up analysis_cluster and fix this, but it's a hard problem and I couldn't crack it last time I tried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a default value for non-alias and non-rule CTs.
This alloows removing many instanceof/cast checks when getting config
conditions.
Part of the work on #11993.