Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ever claim /dev/null is an execpath. #12516

Closed
wants to merge 1 commit into from
Closed

Don't ever claim /dev/null is an execpath. #12516

wants to merge 1 commit into from

Commits on Nov 29, 2020

  1. Don't ever claim /dev/null is an execpath. 

    SpawnInputExpander.EMPTY_FILE claimed an execpath of /dev/null, which could lead to clients trying to do mutating filesystem operations in /dev.

In this change, SpawnInputExpander.EMPTY_FILE is replaced with an EmptyVirtualInput with no execpath. This way errant callers will explode before trying filesystem operations on it. Such a EmptyVirtualInput doesn't really meet the contract of being an ActionInput but that was really already true.
    @benjaminp
    benjaminp committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    ebe480c View commit details
    Browse the repository at this point in the history