Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll rules_proto 97d8af4dc474595af3900dd85cb3a29ad28cc313...7e4afce6fe62dbff0a4a03450143146f9f2d7488 #12372

Closed
wants to merge 2 commits into from
Closed

Roll rules_proto 97d8af4dc474595af3900dd85cb3a29ad28cc313...7e4afce6fe62dbff0a4a03450143146f9f2d7488 #12372

wants to merge 2 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Oct 28, 2020

@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@Yannic Yannic changed the title Roll third_party/rules_proto 97d8af4dc474595af3900dd85cb3a29ad28cc313...7e4afce6fe62dbff0a4a03450143146f9f2d7488 Roll rules_proto 97d8af4dc474595af3900dd85cb3a29ad28cc313...7e4afce6fe62dbff0a4a03450143146f9f2d7488 Oct 28, 2020
@Yannic
Load rules_python before rules_proto in tests
6f321b7 
rules_proto_dependencies() also loads rules_python
@Yannic
Copy link
Contributor Author

Yannic commented Oct 28, 2020

@comius PTAL

Unblocks #12371 & #12037

The tests should pass once https://github.com/bazelbuild/rules_proto/archive/7e4afce6fe62dbff0a4a03450143146f9f2d7488.tar.gz is available on bazel-mirror.

@comius comius self-assigned this Oct 28, 2020
@bazel-io bazel-io closed this in 829b085 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees

@comius comius

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yannic @comius