[1/3] Bump grpc to 1.32.x to fix a too_many_pings regression #12273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmivankov
force-pushed
the
bump_grpc_1_32_x
branch
2 times, most recently
from
fedbab9 to
6e0c32a
Compare
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
bazelbuild#12264
Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266
dmivankov
force-pushed
the
bump_grpc_1_32_x
branch
from
6e0c32a to
4507d9b
Compare
Part 2: switch to v1.32.x grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control which started failing in RBE with io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted HTTP/2 error code: ENHANCE_YOUR_CALM Received Goaway too_many_pings grpc-java v1.32.2 has a bugfix attempt on that grpc v1.32.0 also has something new around keepalive pings Hopefully version bump to those helps bazelbuild#12264 Note: also an attempt and disabling auto flow by default is made in bazelbuild#12266
Part 3: remove 1.31.1 from third_party/grpc grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control which started failing in RBE with io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted HTTP/2 error code: ENHANCE_YOUR_CALM Received Goaway too_many_pings grpc-java v1.32.2 has a bugfix attempt on that grpc v1.32.0 also has something new around keepalive pings Hopefully version bump to those helps bazelbuild#12264 Note: also an attempt and disabling auto flow by default is made in bazelbuild#12266
dmivankov
force-pushed
the
bump_grpc_1_32_x
branch
from
4507d9b to
f77683f
Compare
This reverts commit 6e94b05.
dmivankov
added a commit
to dmivankov/bazel
that referenced
this pull request
Oct 15, 2020
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
Composed PR: bazelbuild#12273
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
bazelbuild#12264
Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266
bazel-io
pushed a commit
that referenced
this pull request
Oct 16, 2020
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
Composed PR: #12273
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
#12264
Note: also an attempt and disabling auto flow by default is made in
#12266
Closes #12279
aiuto
added
the
area-EngProd
aiuto
requested review from
meteorcloudy
and removed request for
meteorcloudy
|
first two parts are merged, last one is just removing old version #12289 |
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
Composed PR: bazelbuild#12273
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
bazelbuild#12264
Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266
Closes bazelbuild#12279
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Oct 22, 2020
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
Composed PR: bazelbuild#12273
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
bazelbuild#12264
Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266
Closes bazelbuild#12279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: add v1.32.x version to third_party/grpc
Note: partly switches to v1.32.x too as not all bits are versioned and
some of unversioned bits are used from other third_party targets
grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings
grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings
Hopefully version bump to those helps
#12264
Note: also an attempt and disabling auto flow by default is made in
#12266