strip remote workspace path from java resources #1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks okay to me, but I'm not too familiar with the Java rules. @damienmg, could you take a look? |
|
LGTM but it needs to passes all the test including internal one. |
bazel-io
pushed a commit
that referenced
this pull request
Apr 5, 2016
Resources in `java_library`s get the external repo path added to them, e.g., `foo` becomes `external/git_remote_repo/foo`. It needs to be removed, though I'm not sure this is the right way to strip it ... -- Reviewed-on: #1085 MOS_MIGRATED_REVID=119024770
|
This was merged, thanks for your contribution! |
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 5, 2022
Resources in `java_library`s get the external repo path added to them, e.g., `foo` becomes `external/git_remote_repo/foo`. It needs to be removed, though I'm not sure this is the right way to strip it ...
--
Reviewed-on: bazelbuild/bazel#1085
MOS_MIGRATED_REVID=119024770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources in
java_librarys get the external repo path added to them, e.g.,foobecomesexternal/git_remote_repo/foo. It needs to be removed, though I'm not sure this is the right way to strip it ...