Attempt to git fetch only specified commit #10137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a corresponding issue? |
aiuto
added
the
team-ExternalDeps
|
Also happy to add tests if someone can provide guidance on where is the appropriate place (git_repository_test.sh? skylark_git_repository_test.sh? GitRepositoryBlackBoxTest.java?). |
HackAttack
force-pushed
the
try-fetch-commit
branch
from
9b15c2f to
c26902c
Compare
The Git server config setting uploadpack.allowReachableSHA1InWant and friends allow git fetch to request a particular commit, which is more efficient than fetching all refs and then checking out the commit locally. Attempt to do this, and fall back to fetching everything if it fails.
HackAttack
force-pushed
the
try-fetch-commit
branch
from
c26902c to
e9fdd35
Compare
|
This seems reasonable and non-breaking, so we won't have to guard it with an incompatible flag. I think it addresses @aehlig's comment about it being opt-in, and no overhead if they server does not support the feature. At least, that was how I read the code. @HackAttack Do you think you can add a test to any of the places you listed? Maybe the black box test. |
philwo
added
the
team-OSS
Yannic
pushed a commit
to Yannic/bazel
that referenced
this pull request
Oct 5, 2020
The Git server config setting uploadpack.allowReachableSHA1InWant and friends allow git fetch to request a particular commit, which is more efficient than fetching all refs and then checking out the commit locally. Attempt to do this, and fall back to fetching everything if it fails. Resolves bazelbuild#8969 Closes bazelbuild#10137. PiperOrigin-RevId: 333298608
philwo
removed
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Git server config setting uploadpack.allowReachableSHA1InWant and friends allow git fetch to request a particular commit, which is more efficient than fetching all refs and then checking out the commit locally. Attempt to do this, and fall back to fetching everything if it fails.
Resolves #8969