Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand documentation about visibility #8982

Closed
laurentlb opened this issue Jul 25, 2019 · 0 comments
Closed

Expand documentation about visibility #8982

laurentlb opened this issue Jul 25, 2019 · 0 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) type: documentation (cleanup)

Comments

@laurentlb
Copy link
Contributor

laurentlb commented Jul 25, 2019 •
edited
Loading

At the moment, we have this documentation: https://docs.bazel.build/versions/0.28.0/be/common-definitions.html#common-attributes

I think it's an important topic, it should be explained in a separate section (not in the attribute documentation).

Things to mention:
@laurentlb laurentlb added type: documentation (cleanup) P2 We'll consider working on this in future. (Assignee optional) team-Starlark labels Jul 25, 2019
@laurentlb laurentlb mentioned this issue Jul 25, 2019
Closed
bazel-io pushed a commit that referenced this issue May 13, 2020
@laurentlb @copybara-github
Move documentation of 'visibility' to a separate page
c44ee62 
Visibility is a core concept (you have to know about when you create a 2nd package).
It shouldn't be hidden in a table, inside the list of common attributes.

I also plan to expand the documentation. Creating a proper section for visibility will leave more space for structuring the content.

This change doesn't modify the content itself (except for one introduction sentence).

#8982

RELNOTES: None.
PiperOrigin-RevId: 311371192
bazel-io pushed a commit that referenced this issue May 13, 2020
@brandjon @copybara-github
Simplify visibility docs
3faaf03 
Correct legacy uses of "rule" terminology to "target". Eliminate extra example verbosity.

Follow-up work to #8982.

RELNOTES: None
PiperOrigin-RevId: 311414362
bazel-io pushed a commit that referenced this issue May 14, 2020
@brandjon @copybara-github
Add mention of package_group's own visibility
13934f0 
Follow-up to #8982.

RELNOTES: None
PiperOrigin-RevId: 311500526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional) type: documentation (cleanup)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurentlb