Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for incompatible_string_join_requires_strings #8507

Closed
laurentlb opened this issue May 29, 2019 · 1 comment
Closed
Assignees
Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong P1 I'll work on this now. (Assignee required)

Comments

@laurentlb
Copy link
Contributor

When the flag --incompatible_string_join_requires_strings is enabled, Baze checks that each element is a string (see #7802).

However, the error message is just a type error. This can be confusing for users who are upgrading Bazel. The error message should at least include the name of the flag.

Since we're flipping the flag in Bazel 0.27, it would be great to improve the error message before that. @jin, @c-parsons, do you have time to do it this week? (tomorrow is public holiday in Germany)

Thanks!

@laurentlb laurentlb added P1 I'll work on this now. (Assignee required) team-Starlark bad error messaging Issues where users get stuck because they don't understand what they did wrong labels May 29, 2019
@jin
Copy link
Member

jin commented May 30, 2019

I can take a stab at this.

jin added a commit to jin/bazel that referenced this issue May 30, 2019
Fixes bazelbuild#8507

Change-Id: I584cbfbd68fb88248455ee41a529368127a8cef3
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
Fixes bazelbuild#8507

Closes bazelbuild#8519.

Change-Id: Ia2967b8765a6f47094dd382a8c963ec01132066c
PiperOrigin-RevId: 250705179
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
Fixes bazelbuild#8507

Closes bazelbuild#8519.

Change-Id: Ia2967b8765a6f47094dd382a8c963ec01132066c
PiperOrigin-RevId: 250705179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants