Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runfiles don't work well for external repositories #848

Closed
kchodorow opened this issue Feb 4, 2016 · 2 comments
Closed

Runfiles don't work well for external repositories #848

kchodorow opened this issue Feb 4, 2016 · 2 comments
Assignees
@kchodorow
Labels
P1 I'll work on this now. (Assignee required) type: feature request

Comments

@kchodorow
Copy link
Contributor

See https://docs.google.com/document/d/1skNx5o-8k5-YXUAyEETvr39eKoh9fecJbGUquPh5iy8/edit.
@kchodorow kchodorow added P2 We'll consider working on this in future. (Assignee optional) external repositories labels Feb 4, 2016
@kchodorow kchodorow self-assigned this Feb 4, 2016
@damienmg damienmg added type: feature request P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Feb 15, 2016
@kchodorow kchodorow mentioned this issue Mar 25, 2016
Closed
bazel-io pushed a commit that referenced this issue Apr 22, 2016
@damienmg
Automated [] rollback of commit 857cda2 and commit 790d2f6.
9e4c78f 
*** Reason for rollback ***

Broke non-Bazel projects on ci.bazel.io

Fixes #1168

*** Original change description ***

Move the runfiles for external repositories to under the x.runfiles/ directory

This also sets the Bazel workspace name to io_bazel_source.

Fixes #848.

Relevant to #1116, #1124,

RELNOTES[INC]: All repositories are now directly under the x.runfiles directory in the runfiles tree (previously, external repositories were at x.runfiles/main-repo/external/other-repo. This simplifies handling remote repository runfiles considerably, but will break existing references to external repository runfiles....

***

--
MOS_MIGRATED_REVID=120535721
@kchodorow kchodorow reopened this Apr 22, 2016
@kchodorow
Copy link
Contributor Author

Continuing notes from #1168:

  • TF serving: no workspace name set, working on a CL to fix them.
  • SkyDoc: CL out for review, note that the tests are broken, though, so this CL fixes the build but doesn't actually get skydoc to green.
  • Tutorial: android fix out for review.
  • Rust: failures were not actually this CL's fault, AFAICT.
  • Closure: the test failure I linked to in Every projects on ci.bazel.io are red on Jenkins #1168 was actually from the source manifest caching issue, http://ci.bazel.io/job/rules_closure/58/ is the actual run. I don't have my OS X laptop today and cannot reproduce the circular dep in Linux.

@kchodorow
Copy link
Contributor Author

Sent out https://github.com/tensorflow/serving/pull/51/files for tensorflow/serving.

bazel-io pushed a commit that referenced this issue Apr 22, 2016
@kchodorow @damienmg
Make suffix a PathFragment
7ef0251 
Breaking up the runfiles tree change into some smaller changes this time around.

First step of rolling forward #848.

--
MOS_MIGRATED_REVID=120553288
bazel-io pushed a commit that referenced this issue Apr 25, 2016
@kchodorow @meteorcloudy
Add a --legacy_external_runfiles option
8dba2b2 
This isn't hooked up to anything yet, but is another piece of getting #848
rolled forward.

--
MOS_MIGRATED_REVID=120582973
bazel-io pushed a commit that referenced this issue Apr 25, 2016
@kchodorow @meteorcloudy
Add the workspace name to the SDK path
6ba22c0 
This makes the android rules work if the workspace name is set.

See https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure
for more details.

This is required for rolling forward #848.

--
MOS_MIGRATED_REVID=120705755
bazel-io pushed a commit that referenced this issue Apr 26, 2016
@kchodorow @meteorcloudy
Create runfiles at both .runfiles/ws/external/repo and .runfiles/repo
d912197 
The major piece of #848.

RELNOTES[INC]: All repositories are now directly under the x.runfiles directory in the runfiles tree (previously, external repositories were at x.runfiles/main-repo/external/other-repo. This simplifies handling remote repository runfiles considerably, but will break existing references to external repository runfiles.

--
MOS_MIGRATED_REVID=120722312
bazel-io pushed a commit to bazelbuild/skydoc that referenced this issue May 3, 2016
@kchodorow
Add workspace name and fix runfiles lookup
cdb1113 
We are going to be changing the runfiles tree structure, which means
that runfiles will need to include the workspace name. See
https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure
for details, in particular the [no workspace name](https://github.com/bazelbuild/bazel/wiki/Updating-the-runfiles-tree-structure#incompatibility-with-no-workspace-name)
section.

This is part of rolling bazelbuild/bazel#848 forward.

RELNOTES: Workspace name is now io_bazel_skydoc.

--
MOS_MIGRATED_REVID=120566529
@kchodorow kchodorow mentioned this issue May 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kchodorow kchodorow

Labels
P1 I'll work on this now. (Assignee required) type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kchodorow @damienmg