Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exec_compatible_with on cc_binary/cc_library. #8026

Closed
bwkimmel opened this issue Apr 12, 2019 · 4 comments
Closed

Support exec_compatible_with on cc_binary/cc_library. #8026

bwkimmel opened this issue Apr 12, 2019 · 4 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@bwkimmel
Copy link

ATTENTION! Please read and follow:

Description of the problem / feature request:

Currently, exec_compatible_with is only available on genrules, shell rules and *_test: https://docs.bazel.build/versions/master/be/common-definitions.html#exec_compatible_with

Feature requests: what underlying problem are you trying to solve with this feature?

A Remote Build Execution customer has a C++ compile action which runs out of memory on n1-standard-2 machines, and it would be more cost-effective for them if they could target a small pool of larger machines, rather than replacing all of their machines with larger machines.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Replace this line with your answer.

What operating system are you running Bazel on?

0.23.2

What's the output of bazel info release?

Don't know (reporting for a customer).

If bazel info release returns "development version" or "(@Non-Git)", tell us how you built Bazel.

N/A

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

N/A

Have you found anything relevant by searching the web?

No

Any other information, logs, or outputs that you want to share?

@aiuto aiuto added bad error messaging Issues where users get stuck because they don't understand what they did wrong team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged labels Apr 15, 2019
@gregestren
Copy link
Contributor

@katre for triage

@katre katre added P2 We'll consider working on this in future. (Assignee optional) type: feature request and removed bad error messaging Issues where users get stuck because they don't understand what they did wrong untriaged labels Apr 15, 2019
@katre
Copy link
Member

katre commented Apr 15, 2019

This is a fairly simple request to implement, the open question is "which rules should allow adding exec_compatible_with?"

Right now, the answer is:

  1. sh_*
  2. *_test
  3. genrule

@katre
Copy link
Member

katre commented Apr 24, 2019

Discussed this today with the configurability team, and we decided to just throw it open and not restrict the target types. I'll send a PR shortly.

katre added a commit to katre/bazel that referenced this issue Apr 24, 2019
the execution platform.

Remove the ExecutionPlatformConstraintsAllowed enum entirely.

Part of work on bazelbuild#8026.
@katre
Copy link
Member

katre commented Apr 24, 2019

Okay, not as easy as a single PR.

Plan:

  1. Send a short PR that defaults to enable exec_compatible_with for all native rules. May also deprecate the RuleClass.Builder method that controls this.
  2. Create an incompatible change issue to track removing the execution_platform_constraints_allowed from the rule() method in Starlark.
  3. Then remove the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants