Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for the Java singlejar implementation #7365

Closed
cushon opened this issue Feb 6, 2019 · 1 comment
Closed

Remove support for the Java singlejar implementation #7365

cushon opened this issue Feb 6, 2019 · 1 comment
Labels
area-java-toolchains javabase, java_toolchain flags, JDK selection, java_toolchain rules, java_tools repository P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules type: process

Comments

@cushon
Copy link
Contributor

cushon commented Feb 6, 2019

Previously: #2241

The Java implementation of singlejar has been replaced by a faster c++ implementation everywhere except:

  • RBE, because of issues with a dependency on c++ protos
  • some places in the bootstrap build, where it might be tricky to use the native implementation but where other zip tools might be fine (it's not very performance-critical)
  • I'm not sure the c++ implementation works on arm yet

We should use the c++ implementation everywhere, and stop supporting the legacy Java singlejar.
@dslomov dslomov added team-Rules-Java Issues for Java rules untriaged labels Feb 11, 2019
@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) P2 We'll consider working on this in future. (Assignee optional) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Mar 13, 2019
@lberki
Copy link
Contributor

lberki commented Mar 13, 2019

Would be indeed nice!

@lberki lberki removed the untriaged label Mar 13, 2019
@comius comius added the area-java-toolchains javabase, java_toolchain flags, JDK selection, java_toolchain rules, java_tools repository label Nov 21, 2020
comius added a commit to comius/bazel that referenced this issue Jan 14, 2021
@comius
Remove support for the Java singlejar implememntation
cf583a3 
Resolves bazelbuild#7365
comius added a commit to comius/bazel that referenced this issue Jan 14, 2021
@comius
Remove support for the Java singlejar implememntation
eaadc6d 
Resolves bazelbuild#7365
@comius comius mentioned this issue Jan 14, 2021
Closed
@kigero kigero mentioned this issue Feb 4, 2021
Closed
katre added a commit that referenced this issue Apr 19, 2021
@katre
Remove SingleJar from IJ project
0aa33e2 
It was removed because of #7365.
@katre katre mentioned this issue Apr 19, 2021
Closed
bazel-io pushed a commit that referenced this issue Apr 19, 2021
@katre @copybara-github
Remove SingleJar from IJ project
db8a7b5 
It was removed because of #7365.

Closes #13370.

PiperOrigin-RevId: 369212525
bazel-io pushed a commit that referenced this issue Nov 6, 2021
@hvadehra @copybara-github
Deletes non-native singlejar support in native java rules
fad4933 
Removal is now possible since the following issues are resolved:
#2241
#7365

PiperOrigin-RevId: 408004890
@nehaljwani nehaljwani mentioned this issue Feb 14, 2022
Merged
3 tasks
@cushon cushon mentioned this issue Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-java-toolchains javabase, java_toolchain flags, JDK selection, java_toolchain rules, java_tools repository P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules type: process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for the Java singlejar implementation comius/bazel
4 participants
@cushon @comius @lberki @dslomov