Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//scripts/packages:without-jdk/bazel includes a jdk #7167

Closed
emidln opened this issue Jan 17, 2019 · 1 comment
Closed

//scripts/packages:without-jdk/bazel includes a jdk #7167

emidln opened this issue Jan 17, 2019 · 1 comment
Assignees
@meisterT
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Rules-Java Issues for Java rules

Comments

@emidln
Copy link

emidln commented Jan 17, 2019 •
edited
Loading

//scripts/packages:rename-bazel-bin-without-jdk, which produces //scripts/packages:without-jdk/bazel includes //src:bazel[0], which due to semi-recent changes, now includes a jdk. It should be changed to //src:bazel_nojdk to support generating a bazel.sh without an embedded JDK. This change seems to have been missed by 7c49bd9

[0] As of c67dcec
@jin jin added area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling untriaged labels Jan 17, 2019
@jin
Copy link
Member

jin commented Jan 17, 2019

cc @meisterT

meisterT added a commit to meisterT/bazel that referenced this issue Jan 18, 2019
@meisterT
Use bazel without JDK in //scripts/packages:without-jdk/bazel.
86efb6f 
Fixes bazelbuild#7167.

RELNOTES: None
@meisterT meisterT mentioned this issue Jan 18, 2019
Closed
@meisterT meisterT self-assigned this Jan 18, 2019
@meisterT meisterT added team-Rules-Java Issues for Java rules P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jan 18, 2019
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this issue Jan 31, 2019
@meisterT @weixiao-huang
Use bazel without JDK in //scripts/packages:without-jdk/bazel.
b403047 
Fixes bazelbuild#7167.

RELNOTES: None

Closes bazelbuild#7172.

PiperOrigin-RevId: 229890772
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meisterT meisterT

Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jin @meisterT @philwo @emidln