Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.5.3 #3375

Closed
buchgr opened this issue Jul 13, 2017 · 46 comments
Closed

Release 0.5.3 #3375

buchgr opened this issue Jul 13, 2017 · 46 comments
Assignees
@buchgr
Labels
P1 I'll work on this now. (Assignee required) type: process

Comments

@buchgr
Copy link
Contributor

buchgr commented Jul 13, 2017

Mostly, because of remote execution fixes.
@buchgr buchgr added category: misc > release / binary P1 I'll work on this now. (Assignee required) type: process labels Jul 13, 2017
@buchgr buchgr self-assigned this Jul 13, 2017
@buchgr buchgr mentioned this issue Jul 13, 2017
Closed
@iirina
Copy link
Contributor

iirina commented Jul 17, 2017

Hi Jakob, have you cut a RC yet? What baseline have you used?

I suggest we go back to posting all the updates on the release, including what commands were used to create each RC

@buchgr
Copy link
Contributor Author

buchgr commented Jul 17, 2017

No I haven't cut a RC yet. Will do once we cut the RC.

@aehlig
Copy link
Contributor

aehlig commented Jul 17, 2017 via email

@aehlig
Copy link
Contributor

aehlig commented Jul 17, 2017 via email

@buchgr
Copy link
Contributor Author

buchgr commented Jul 18, 2017

We are working on a fix for the broken release procedure.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 18, 2017

0.5.3rc2 has just been created [1]. It contains 820a46a as a cherry-pick.

[1] https://groups.google.com/forum/#!topic/bazel-discuss/MJ7N5K4MD_o

@philwo
Copy link
Member

philwo commented Jul 19, 2017

Hi @buchgr,

would you mind cherry-picking ccfb2df into 0.5.3? It contains an important fix for Windows that is currently blocking us from removing dependencies on bash (and we need it in a released Bazel in order to move forward, so that we don't break backwards compatibility of Bazel building Bazel).

Thanks,
Philipp

@petemounce
Copy link
Contributor

https://chocolatey.org/packages/bazel/0.5.3-rc2 has been pushed. Missed this issue again, apologies for delay. Would be lovely to get an @ for release activity?

@buchgr
Copy link
Contributor Author

buchgr commented Jul 19, 2017

@petemounce thanks! will do for 0.6.0. Sorry!

@buchgr
Copy link
Contributor Author

buchgr commented Jul 20, 2017

Also cherry-pick 9a45f55afc53d1844921bc90c1153ac449515f9e

@dslomov
Copy link
Contributor

dslomov commented Jul 21, 2017

Please make sure is in 9c54e2a (it is already before the baseline commit, just for the record)

@vladmos
Copy link
Member

vladmos commented Jul 21, 2017

Hello, please cherry-pick 0653491 if it's not in the RC.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 21, 2017

Will do. I am planning on doing another RC next Tuesday (25/07).

@aehlig aehlig mentioned this issue Jul 21, 2017
Closed
@buchgr
Copy link
Contributor Author

buchgr commented Jul 24, 2017

Bazel 0.5.3rc3 has been released. Please test!

https://groups.google.com/forum/#!topic/bazel-discuss/opbZudzQ1Lg

@ittaiz
Copy link
Member

ittaiz commented Jul 24, 2017 via email

@petemounce
Copy link
Contributor

The naming pattern of the artifacts has changed in a breaking way, so I'll issue a PR to change the chocolatey build package scripts to account for that. I'll publish the PR from that directly.

@petemounce
Copy link
Contributor

@buchgr actually, the zip artifact that the chocolatey package depends on is no longer being published by your CI. Please reinstate this?

Based on https://storage.googleapis.com/bazel/0.5.3/rc3/bazel-0.5.3rc3-windows-x86_64.exe I am expecting https://storage.googleapis.com/bazel/0.5.3/rc3/bazel-0.5.3rc3-windows-x86_64.zip to exist and contain the corresponding binary.

I won't be able to release the RC without that artifact or more major surgery to the chocolatey package. I'd prefer the artifact to be reinstated.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 24, 2017

@ittaiz we are still waiting for feedback from some users. Should be out of EOW.

@petemounce thanks for the feedback. Will take a look...

bazel-io pushed a commit that referenced this issue Jul 24, 2017
@damienmg @buchgr
Automated rollback of commit 820a46a.
5e57663 
*** Reason for rollback ***

Now the new jenkins pipeline has been rolled forward we actually needs that change

To cherry-pick for #3375

*** Original change description ***

Automated rollback of commit 6d6e872.

*** Reason for rollback ***

Does not work so well, see https://storage.googleapis.com/bazel/0.5.3/rc1/index.html

*** Original change description ***

Release script: generate the index.html from the commit message

Do not rely on the README.md anymore, because it relies on log
still existing forever on Jenkins. Incoming change will just provides
the log as a file that will be archived on GCS.

PiperOrigin-RevId: 162950464
bazel-io pushed a commit that referenced this issue Jul 25, 2017
@damienmg @buchgr
Create Windows ZIP release artifact using Bazel
9a63aff 
The new pipeline does not support ziping artifact which was
a custom hack for Windows, relies on Bazel to generate those
zip instead.

Step forward fixing bazelbuild/continuous-integration#101
To cherry-pick for #3375.

Change-Id: Id566d66bb179096d60c5b535f245d64cea28c5b8
PiperOrigin-RevId: 163054883
damienmg added a commit that referenced this issue Jul 25, 2017
@damienmg
Use the correct function to generate the release notes
aa872f8 
To be cherry-picked for #3375

Change-Id: I81e3660d1e01935101a19d75e1a696296df1941d
@philwo
Copy link
Member

philwo commented Jul 26, 2017

In case you do another RC, please cherry-pick this fix for macOS sandboxing as requested by @ittaiz:
cd159bc

Thanks!

@philwo
Copy link
Member

philwo commented Jul 26, 2017

And if possible ad73cba, which is a simple fix to improve backwards compatibility of our Python wrapper so that it works with Python 2.4.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 26, 2017

release.sh create --force_rc=4 0.5.3 8851852 820a46a ccfb2df 0653491 cd159bc ad73cba 9a63aff 5e57663 b6e29ca

@petemounce
Copy link
Contributor

Wonderful, thanks.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 26, 2017

0.5.3 rc4 is out: https://storage.googleapis.com/bazel/0.5.3/rc4/index.html

@petemounce
Copy link
Contributor

Published https://chocolatey.org/packages/bazel/0.5.3-rc4

@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

Cherry-pick: 1cbba98

@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

Cherry-pick: 562fcf9

bazel-io pushed a commit that referenced this issue Jul 27, 2017
@damienmg @buchgr
Include <cinttypes> instead of <stdint.h>
0f3481b 
cinttypes is the C++ header that should replace stdint.h. Not
using the correct header was leading to compilation error on CentOS 6.7

Fixes #3455.
To be cherry-picked for #3375.

Change-Id: I6df22134a4a4902ec9fa7ecdfaeb5408eacf3564
PiperOrigin-RevId: 163334651
@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

Cherry-pick: 815bd63

@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

Cherry-pick: 0f3481b

@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

I am happy to announce that bazel 0.5.3 has just been released: https://groups.google.com/forum/#!topic/bazel-discuss/np39cH-nvTY

Unfortunately, we were unable to cherry pick the remote execution changes 1cbba98, 562fcf9, 815bd63 into the release, as this part of the code has substantially changed since the baseline and thus any such cherry picks failed.

We will thus start the release process for 0.5.4 immediately, with a new baseline that contains these commits.

ping @petemounce

@buchgr buchgr closed this as completed Jul 27, 2017
@buchgr buchgr reopened this Jul 27, 2017
@buchgr
Copy link
Contributor Author

buchgr commented Jul 27, 2017

#3459 ... our release pipeline failed for windows, so @damienmg seems to suggest we need to create a new 0.5.3 release for windows?

@petemounce
Copy link
Contributor

Thanks for the ping! Will probably push later on.

@damienmg
Copy link
Contributor

I think we can work out something to just rerun the release job and get the job to works, @petemounce I suggest to follow-up on #3459

@petemounce
Copy link
Contributor

Published https://chocolatey.org/packages/bazel/0.5.3

@petemounce
Copy link
Contributor

I've adjusted the package build scripts in #3466 to cope with the rename.

@buchgr
Copy link
Contributor Author

buchgr commented Jul 31, 2017

thanks @petemounce

@laszlocsomor
Copy link
Contributor

Oops, sorry, I see it was reopened for a reason.

@laszlocsomor laszlocsomor reopened this Aug 2, 2017
@buchgr buchgr closed this as completed Aug 2, 2017
@buchgr
Copy link
Contributor Author

buchgr commented Aug 2, 2017

can be closed.

@meteorcloudy
Copy link
Member

Is there a way to add the influence of a5c3862 into 0.5.3 release note? I've seen at least two cases where people think it's a regression.

Basically the change is

--python3_path and --python2_path are deprecated, and introduced a new option --python_path.

@buchgr
Copy link
Contributor Author

buchgr commented Aug 7, 2017

@meteorcloudy no, but we can mention it in the 0.5.4. release notes? Should be out this or next week.

@damienmg
Copy link
Contributor

damienmg commented Aug 7, 2017 via email

abergmeier-dsfishlabs pushed a commit to abergmeier-dsfishlabs/bazel that referenced this issue Aug 23, 2017
@damienmg @buchgr
Create Windows ZIP release artifact using Bazel
0771a75 
The new pipeline does not support ziping artifact which was
a custom hack for Windows, relies on Bazel to generate those
zip instead.

Step forward fixing bazelbuild/continuous-integration#101
To cherry-pick for bazelbuild#3375.

Change-Id: Id566d66bb179096d60c5b535f245d64cea28c5b8
PiperOrigin-RevId: 163054883
abergmeier-dsfishlabs pushed a commit to abergmeier-dsfishlabs/bazel that referenced this issue Aug 23, 2017
@damienmg @buchgr
Automated rollback of commit 820a46a.
4a1b0fa 
*** Reason for rollback ***

Now the new jenkins pipeline has been rolled forward we actually needs that change

To cherry-pick for bazelbuild#3375

*** Original change description ***

Automated rollback of commit 6d6e872.

*** Reason for rollback ***

Does not work so well, see https://storage.googleapis.com/bazel/0.5.3/rc1/index.html

*** Original change description ***

Release script: generate the index.html from the commit message

Do not rely on the README.md anymore, because it relies on log
still existing forever on Jenkins. Incoming change will just provides
the log as a file that will be archived on GCS.

PiperOrigin-RevId: 162950464
abergmeier-dsfishlabs pushed a commit to abergmeier-dsfishlabs/bazel that referenced this issue Aug 23, 2017
@damienmg @buchgr
Use the correct function to generate the release notes
689c011 
To be cherry-picked for bazelbuild#3375

Change-Id: I81e3660d1e01935101a19d75e1a696296df1941d
PiperOrigin-RevId: 163202698
abergmeier-dsfishlabs pushed a commit to abergmeier-dsfishlabs/bazel that referenced this issue Aug 23, 2017
@damienmg @buchgr
Include <cinttypes> instead of <stdint.h>
4b82b97 
cinttypes is the C++ header that should replace stdint.h. Not
using the correct header was leading to compilation error on CentOS 6.7

Fixes bazelbuild#3455.
To be cherry-picked for bazelbuild#3375.

Change-Id: I6df22134a4a4902ec9fa7ecdfaeb5408eacf3564
PiperOrigin-RevId: 163334651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buchgr buchgr

Labels
P1 I'll work on this now. (Assignee required) type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests