Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document git workspace SHA1 inclusion in C++ builds #2893

Closed
htuch opened this issue Apr 26, 2017 · 2 comments
Closed

Document git workspace SHA1 inclusion in C++ builds #2893

htuch opened this issue Apr 26, 2017 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)

Comments

@htuch
Copy link

htuch commented Apr 26, 2017 •
edited
Loading

Today, the best reference I can find for this is https://groups.google.com/forum/m/#!topic/bazel-discuss/9kqLmOq_m_U. The public docs (e.g. Build Encyclopedia) don't mention many of the details. For example linkstamp for cc_library is not documented, nor is --workspace_status_command or the reference workspace status command tools/buildstamp/get_workspace_status (which is not the default).

We spent quite some time in the Envoy project during our Bazel conversion on getting a live git SHA1 since we were unaware of these mechanisms, mucking around with genrule and repository_rule. I think it would be beneficial to document this clearly, as this is a very core thing a build system needs to be able to do for any non-trivial project that does production releases.

@mattklein123
@htuch htuch mentioned this issue Apr 26, 2017
Closed
htuch added a commit to htuch/envoy that referenced this issue Apr 26, 2017
@htuch
version/bazel: fix git SHA1 embedding story.
e6afab8 
This is an alternative to envoyproxy#841, using the technique described in
https://groups.google.com/forum/m/#!topic/bazel-discuss/9kqLmOq_m_U. See also
bazelbuild/bazel#2893.
@htuch htuch mentioned this issue Apr 26, 2017
Merged
mattklein123 pushed a commit to envoyproxy/envoy that referenced this issue Apr 27, 2017
@htuch @mattklein123
version/bazel: fix git SHA1 embedding story. (#843)
3ea5d3b 
This is an alternative to #841, using the technique described in
https://groups.google.com/forum/m/#!topic/bazel-discuss/9kqLmOq_m_U. See also
bazelbuild/bazel#2893.
This was referenced Apr 27, 2017
Closed
Merged
Closed
@htuch htuch mentioned this issue Feb 16, 2018
Closed
@hlopko hlopko added team-Rules-CPP Issues for C++ rules and removed category: rules > C++ labels Oct 11, 2018
@junr03 junr03 mentioned this issue May 8, 2019
Open
@c-mita c-mita added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 24, 2020
@sgowroji sgowroji added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Jan 11, 2023
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 17, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vladmos @hlopko @c-mita @htuch @sgowroji