Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_go & rules_python are failing in Downstream CI with Bazel@HEAD #18346

Closed
sgowroji opened this issue May 8, 2023 · 4 comments
Closed

rules_go & rules_python are failing in Downstream CI with Bazel@HEAD #18346

sgowroji opened this issue May 8, 2023 · 4 comments
Assignees
@SalmaSamy
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests breakage P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@sgowroji
Copy link
Member

sgowroji commented May 8, 2023

rules_go: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3007#0187f91d-2018-4dd0-b272-79d934978ac3
rules_python : https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3007#0187f91d-2990-4989-9b6e-68aaf097469e

Logs:

(04:08:41) ERROR: /Users/buildkite/builds/bk-imacpro-12/bazel-downstream-projects/rules_go/tests/bcr/proto/BUILD.bazel:30:8: no such package '@gazelle~0.30.0~go_deps~org_golang_google_grpc//': no such package '@gazelle~0.30.0~go_deps~bazel_gazelle_go_repository_config//': error loading package '': Bzlmod system contains .bzl load visibility violations and referenced by '//proto:foo_grpc_test'
(04:08:41) ERROR: Analysis of target '//proto:foo_grpc_test' failed; build aborted: Analysis failed
(04:08:41) INFO: Elapsed time: 10.960s
(04:08:41) INFO: 0 processes.
(04:08:41) ERROR: Build did NOT complete successfully

Caused by a6ebf07 :

CC @meteorcloudy
@meteorcloudy
Copy link
Member

/cc @SalmaSamy @Wyverald

@meteorcloudy meteorcloudy added type: bug P1 I'll work on this now. (Assignee required) breakage area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels May 8, 2023
@meteorcloudy
Copy link
Member

Should be reproducible with https://github.com/bazelbuild/rules_python/tree/main/examples/bzlmod_build_file_generation

@fmeum fmeum mentioned this issue May 9, 2023
Closed
@Wyverald Wyverald removed their assignment May 15, 2023
@fmeum
Copy link
Collaborator

fmeum commented May 16, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 16, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io mentioned this issue May 16, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 16, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this issue May 18, 2023
@SalmaSamy @iancha1992
Stop checking .bzl files visibility in RepoRuleFunction
c630a7c 
Fixes bazelbuild#18346

At this point we are creating a rule from an extension repospec and that is always public

PiperOrigin-RevId: 532558852
Change-Id: I245de0a23f92ba6283be4bf3be6af4863b7a8c68
@iancha1992 iancha1992 mentioned this issue May 18, 2023
Merged
iancha1992 added a commit that referenced this issue May 19, 2023
@iancha1992 @SalmaSamy
[6.3.0] rules_go & rules_python are failing in Downstream CI with Baz…
71cfbba 
…el@HEAD (#18447)

* Store repospec instead of package for module extension

PiperOrigin-RevId: 529679264
Change-Id: Ib9d410f5de1bac171c3c6f642b8584986181e44b

* Stop checking .bzl files visibility in RepoRuleFunction
Fixes #18346

At this point we are creating a rule from an extension repospec and that is always public

PiperOrigin-RevId: 532558852
Change-Id: I245de0a23f92ba6283be4bf3be6af4863b7a8c68

---------

Co-authored-by: salma-samy <salmasamy@google.com>
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
@SalmaSamy @fweikert
Stop checking .bzl files visibility in RepoRuleFunction
e543526 
Fixes bazelbuild#18346

At this point we are creating a rule from an extension repospec and that is always public

PiperOrigin-RevId: 532558852
Change-Id: I245de0a23f92ba6283be4bf3be6af4863b7a8c68
@tylerwilliams tylerwilliams mentioned this issue Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SalmaSamy SalmaSamy

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests breakage P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Wyverald @meteorcloudy @fmeum @bazel-io @SalmaSamy @sgowroji @iancha1992