Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests that require exclusive access to hardware to be run without the exclusive tag. #16817

Closed
drewmacrae opened this issue Nov 22, 2022 · 1 comment
Assignees
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request

Comments

@drewmacrae
Copy link
Contributor

Description of the feature request:

In OpenTitan, we use bazel to coordinate and direct tests, and we have long running tests on simulators and on FPGAs. The FPGA tests require exclusive access to attached FPGAs, but don't conflict with any of the non-FPGA actions in our WORKSPACE.
#16785 and it's predecessors offer a means to introduce extra resources like our fpga boards and issue tests in parallel with other actions, but without issuing multiple tests that require the FPGAs.

I can't find an open issue referenced in this work so I'm writing it up

What underlying problem are you trying to solve with this feature?

We're trying to make our WORKSPACE aware of resource limitations that aren't covered by the CPU/Memory limits and aren't covered by "exclusive" tags or controlling the number of jobs without incurring a large overhead.

Which operating system are you running Bazel on?

Rolling debian testing Rodette

What is the output of bazel info release?

release 5.3.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

https://github.com/bazelbuild/bazel
d2aaf0cd66f10745aedee16330c2c053b848a507
ea1646d8d58f5252e55bb891b5eaee67778f23c7

Have you found anything relevant by searching the web?

More discussion here: #16785

Any other information, logs, or outputs that you want to share?

No response

@sgowroji sgowroji added type: feature request team-Performance Issues for Performance teams untriaged team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Nov 22, 2022
@wilwell wilwell self-assigned this Nov 29, 2022
@wilwell wilwell added team-Local-Exec Issues and PRs for the Execution (Local) team and removed untriaged team-Performance Issues for Performance teams team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Nov 29, 2022
copybara-service bot pushed a commit that referenced this issue Dec 30, 2022
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
drewmacrae pushed a commit to drewmacrae/bazel that referenced this issue Jan 17, 2023
This recreates a [closed PR](bazelbuild#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:bazelbuild#16817

Closes bazelbuild#16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
ShreeM01 added a commit that referenced this issue Jan 19, 2023
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68

Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
hvadehra pushed a commit that referenced this issue Feb 14, 2023
This recreates a [closed PR](#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
@eric-skydio
Copy link

I think this is resolved now, if #17229 works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants