Make grep_includes optional inside cc_common.register_linkstamp_compi…

…le_action (#18823) * Make grep_includes optional inside register_linkstamp_compile_action * Update CcModule.java
bazelbuild · Jun 30, 2023 · e0dcb24 · e0dcb24
1 parent d2724ba
commit e0dcb24
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java
@@ -2629,7 +2629,12 @@ private static void validateExtensions(
             doc = "<code>feature_configuration</code> to be queried.",
             positional = false,
             named = true),
-        @Param(name = "grep_includes", documented = false, positional = false, named = true),
+        @Param(
+            name = "grep_includes",
+            documented = false,
+            positional = false,
+            named = true,
+            defaultValue = "None"),
         @Param(name = "source_file", documented = false, positional = false, named = true),
         @Param(name = "output_file", documented = false, positional = false, named = true),
         @Param(name = "compilation_inputs", documented = false, positional = false, named = true),
@@ -2645,7 +2650,7 @@ public void registerLinkstampCompileAction(
       StarlarkActionFactory starlarkActionFactoryApi,
       CcToolchainProvider ccToolchain,
       FeatureConfigurationForStarlark featureConfigurationForStarlark,
-      Artifact grepIncludes,
+      Object grepIncludes,
       Artifact sourceFile,
       Artifact outputFile,
       Depset compilationInputs,
@@ -2664,7 +2669,7 @@ public void registerLinkstampCompileAction(
             CppLinkstampCompileHelper.createLinkstampCompileAction(
                 ruleContext,
                 ruleContext,
-                grepIncludes,
+                convertFromNoneable(grepIncludes, /* defaultValue= */ null),
                 ruleContext.getConfiguration(),
                 sourceFile,
                 outputFile,