Skip to content

Commit

Permalink
Update rules_java to 6.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
meteorcloudy committed May 25, 2023
1 parent 375c198 commit 9c8e612
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 18 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ bazel_dep(name = "stardoc", version = "0.5.3", repo_name = "io_bazel_skydoc")
bazel_dep(name = "zstd-jni", version = "1.5.2-3")
bazel_dep(name = "zlib", version = "1.2.13")
bazel_dep(name = "rules_cc", version = "0.0.6")
bazel_dep(name = "rules_java", version = "5.5.0")
bazel_dep(name = "rules_java", version = "6.0.0")
bazel_dep(name = "rules_proto", version = "5.3.0-21.7")
bazel_dep(name = "rules_jvm_external", version = "4.5")
bazel_dep(name = "rules_python", version = "0.19.0")
Expand Down
12 changes: 4 additions & 8 deletions distdir_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,17 @@ DIST_DEPS = {
"package_version": "0.0.6",
"strip_prefix": "rules_cc-0.0.6",
},
# TODO(pcloudy): DO NOT SUBMIT: Switch to release version of rules_java
"rules_java": {
"archive": "fe9bd0703e255efcf9a27ee7dfe99aa20e3fb7aa.tar.gz",
"sha256": "103306d728ff723e933c8fb34d09d145c0085bdbf8a804faeb46be67b122ae23",
"strip_prefix": "rules_java-fe9bd0703e255efcf9a27ee7dfe99aa20e3fb7aa",
"urls": [
"https://github.com/meteorcloudy/rules_java/archive/fe9bd0703e255efcf9a27ee7dfe99aa20e3fb7aa.tar.gz",
],
"archive": "rules_java-6.0.0.tar.gz",
"sha256": "469b7f3b580b4fcf8112f4d6d0d5a4ce8e1ad5e21fee67d8e8335d5f8b3debab",
"urls": ["https://github.com/bazelbuild/rules_java/releases/download/6.0.0/rules_java-6.0.0.tar.gz"],
"used_in": [
"additional_distfiles",
],
"license_kinds": [
"@rules_license//licenses/spdx:Apache-2.0",
],
"package_version": "5.4.1",
"package_version": "6.0.0",
},
# Used in src/test/java/com/google/devtools/build/lib/blackbox/framework/blackbox.WORKSAPCE
"rules_proto": {
Expand Down
2 changes: 1 addition & 1 deletion src/MODULE.tools
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module(name = "bazel_tools")

bazel_dep(name = "rules_cc", version = "0.0.6")
bazel_dep(name = "rules_java", version = "5.5.0")
bazel_dep(name = "rules_java", version = "6.0.0")
bazel_dep(name = "rules_license", version = "0.0.3")
bazel_dep(name = "rules_proto", version = "4.0.0")
bazel_dep(name = "rules_python", version = "0.4.0")
Expand Down
15 changes: 7 additions & 8 deletions src/test/shell/bazel/bazel_rules_java_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,14 @@ EOF
fail "Bazel failed to build @rules_java"
}

# TODO(pcloudy): Probably don't need to exclude this test if we use a release version of rules_java
# function test_rules_java_repository_builds_itself() {
# write_default_bazelrc
# setup_skylib_support
function test_rules_java_repository_builds_itself() {
write_default_bazelrc
setup_skylib_support

# # We test that a built-in @rules_java repository is buildable.
# bazel build -- @rules_java//... -@rules_java//toolchains/... &> $TEST_log \
# || fail "Build failed unexpectedly"
# }
# We test that a built-in @rules_java repository is buildable.
bazel build -- @rules_java//... -@rules_java//toolchains/... &> $TEST_log \
|| fail "Build failed unexpectedly"
}


function test_experimental_java_library_export_do_not_use() {
Expand Down

0 comments on commit 9c8e612

Please sign in to comment.