Skip to content

Commit

Permalink
Allow oso_prefix_is_pwd to be used with all osx cpp link actions
Browse files Browse the repository at this point in the history
Expands the targeted actions to allow stripping the absolute build path for debug symbols from all libraries.  The support in wrapped_clang is indifferent to whether we are linking a true objc or regular cpp library.

When used in concert with `--features=oso_prefix_is_pwd --remote_download_outputs=all`, allows successful local debugging of executables/libraries built remotely.  Probably also helps with sandboxed actions.

Helps mitigate #6327 and kinda sorta #2537?  See also #11671

Closes #13311.

PiperOrigin-RevId: 404262861
  • Loading branch information
jlaxson authored and copybara-github committed Oct 19, 2021
1 parent 70ee973 commit 9b4844a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/osx/crosstool/cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2353,7 +2353,8 @@ def _impl(ctx):
name = "oso_prefix_is_pwd",
flag_sets = [
flag_set(
actions = ["objc-executable", "objc++-executable"],
actions = all_link_actions +
["objc-executable", "objc++-executable"],
flag_groups = [flag_group(flags = ["OSO_PREFIX_MAP_PWD"])],
),
],
Expand Down

0 comments on commit 9b4844a

Please sign in to comment.