Skip to content

Commit

Permalink
Convert experimental flags to incompatible
Browse files Browse the repository at this point in the history
This cl converts their experimental siblings into:

`--incompatible_dont_emit_static_libgcc`
(#6825)

`--incompatible_linkopts_in_user_link_flags`
(#6826)

RELNOTES:
Added `--incompatible_dont_emit_static_libgcc` (#6825)
Added `--incompatible_linkopts_in_user_link_flags` (#6826)
PiperOrigin-RevId: 223938818
  • Loading branch information
hlopko authored and Copybara-Service committed Dec 4, 2018
1 parent 38f5451 commit 8ae6e12
Showing 1 changed file with 15 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -723,22 +723,30 @@ public Label getFdoPrefetchHintsLabel() {
public boolean disableLegacyCrosstoolFields;

@Option(
name = "experimental_linkopts_in_user_link_flags",
name = "incompatible_linkopts_in_user_link_flags",
oldName = "experimental_linkopts_in_user_link_flags",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.EXPERIMENTAL},
metadataTags = {
OptionMetadataTag.INCOMPATIBLE_CHANGE,
OptionMetadataTag.TRIGGERED_BY_ALL_INCOMPATIBLE_CHANGES
},
help =
"If true, flags coming from --linkopt Bazel option will appear in user_link_flags "
+ "crosstool variable.")
+ "crosstool variable, not in legacy_link_flags.")
public boolean enableLinkoptsInUserLinkFlags;

@Option(
name = "experimental_dont_emit_static_libgcc",
name = "incompatible_dont_emit_static_libgcc",
oldName = "experimental_dont_emit_static_libgcc",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.EXPERIMENTAL},
metadataTags = {
OptionMetadataTag.INCOMPATIBLE_CHANGE,
OptionMetadataTag.TRIGGERED_BY_ALL_INCOMPATIBLE_CHANGES
},
help =
"If true, bazel will not add --static-libgcc to the linking command line, it will be "
+ "the responsibility of the C++ toolchain to append this flag.")
Expand Down

0 comments on commit 8ae6e12

Please sign in to comment.