-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not depend on CppConfiguration to provide CROSSTOOL file to cc_too…
…lchain Use CcSkyframeSupportFunction instead. #6072 RELNOTES: None. PiperOrigin-RevId: 214004051
- Loading branch information
Showing
11 changed files
with
324 additions
and
281 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
src/main/java/com/google/devtools/build/lib/rules/cpp/CcSkyframeSupportFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| // Copyright 2014 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package com.google.devtools.build.lib.rules.cpp; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
| import com.google.devtools.build.lib.actions.FileValue; | ||
| import com.google.devtools.build.lib.analysis.BlazeDirectories; | ||
| import com.google.devtools.build.lib.analysis.config.InvalidConfigurationException; | ||
| import com.google.devtools.build.lib.cmdline.Label; | ||
| import com.google.devtools.build.lib.vfs.FileSystemUtils; | ||
| import com.google.devtools.build.lib.vfs.Path; | ||
| import com.google.devtools.build.lib.vfs.Root; | ||
| import com.google.devtools.build.lib.vfs.RootedPath; | ||
| import com.google.devtools.build.lib.view.config.crosstool.CrosstoolConfig.CrosstoolRelease; | ||
| import com.google.devtools.build.skyframe.SkyFunction; | ||
| import com.google.devtools.build.skyframe.SkyFunctionException; | ||
| import com.google.devtools.build.skyframe.SkyKey; | ||
| import com.google.devtools.build.skyframe.SkyValue; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * A {@link SkyFunction} that does things for FDO that a regular configured target is not allowed | ||
| * to. | ||
| * | ||
| * <p>This only exists because the value of {@code --fdo_optimize} can be a workspace-relative path | ||
| * and thus we need to depend on {@link BlazeDirectories} somehow, which neither the configuration | ||
| * nor the analysis phase can "officially" do. | ||
| * | ||
| * <p>The fix is probably to make it possible for {@link | ||
| * com.google.devtools.build.lib.analysis.actions.SymlinkAction} to create workspace-relative | ||
| * symlinks because action execution can hopefully depend on {@link BlazeDirectories}. | ||
| * | ||
| * <p>There is also the awful and incorrect {@link Path#exists()} call in {@link | ||
| * com.google.devtools.build.lib.view.proto.CcProtoProfileProvider#getProfile( | ||
| * com.google.devtools.build.lib.analysis.RuleContext)} which needs a {@link Path}. | ||
| */ | ||
| public class CcSkyframeSupportFunction implements SkyFunction { | ||
| private final BlazeDirectories directories; | ||
|
|
||
| public CcSkyframeSupportFunction(BlazeDirectories directories) { | ||
| this.directories = Preconditions.checkNotNull(directories); | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public SkyValue compute(SkyKey skyKey, Environment env) | ||
| throws InterruptedException, CcSkyframeSupportException { | ||
| CcSkyframeSupportValue.Key key = (CcSkyframeSupportValue.Key) skyKey.argument(); | ||
| Path fdoZipPath = null; | ||
| CrosstoolRelease crosstoolRelease = null; | ||
| if (key.getFdoZipPath() != null) { | ||
| fdoZipPath = directories.getWorkspace().getRelative(key.getFdoZipPath()); | ||
| } | ||
|
|
||
| if (key.getCrosstoolPath() != null) { | ||
| try { | ||
| Root root; | ||
| // Dear reader, if your eye just twitched and the thought cannot escape your mind that | ||
| // I should've used execroot, beware, execroot is created after the analysis, and this | ||
| // function is executed during the analysis. | ||
| if (key.getCrosstoolPath().startsWith(Label.EXTERNAL_PACKAGE_NAME)) { | ||
| root = Root.fromPath(directories.getOutputBase()); | ||
| } else { | ||
| root = Root.fromPath(directories.getWorkspace()); | ||
| } | ||
| FileValue crosstoolFileValue = | ||
| (FileValue) | ||
| env.getValue(FileValue.key(RootedPath.toRootedPath(root, key.getCrosstoolPath()))); | ||
| if (env.valuesMissing()) { | ||
| return null; | ||
| } | ||
|
|
||
| Path crosstoolFile = crosstoolFileValue.realRootedPath().asPath(); | ||
| try (InputStream inputStream = crosstoolFile.getInputStream()) { | ||
| String crosstoolContent = new String(FileSystemUtils.readContentAsLatin1(inputStream)); | ||
| crosstoolRelease = | ||
| CrosstoolConfigurationLoader.toReleaseConfiguration( | ||
| "CROSSTOOL file " + key.getCrosstoolPath(), crosstoolContent); | ||
| } | ||
| } catch (IOException | InvalidConfigurationException e) { | ||
| throw new CcSkyframeSupportException(e, key); | ||
| } | ||
| } | ||
|
|
||
| return new CcSkyframeSupportValue(fdoZipPath, crosstoolRelease); | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public String extractTag(SkyKey skyKey) { | ||
| return null; | ||
| } | ||
|
|
||
| /** Exception encapsulating IOExceptions thrown in {@link CcSkyframeSupportFunction} */ | ||
| public static class CcSkyframeSupportException extends SkyFunctionException { | ||
|
|
||
| public CcSkyframeSupportException(Exception cause, SkyKey childKey) { | ||
| super(cause, childKey); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 0 additions & 63 deletions
63
src/main/java/com/google/devtools/build/lib/rules/cpp/CcSupportFunction.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.