Skip to content

Commit

Permalink
Revert linker changes
Browse files Browse the repository at this point in the history
  • Loading branch information
keith committed Oct 29, 2020
1 parent 3686114 commit 4f6d6d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ private static ExtraLinkArgs getRequiredLinkopts(RuleContext ruleContext)
switch (binaryType) {
case LOADABLE_BUNDLE:
extraLinkArgs.add("-bundle");
extraLinkArgs.add("-Wl,-rpath,@loader_path/Frameworks");
extraLinkArgs.add("-Xlinker", "-rpath", "-Xlinker", "@loader_path/Frameworks");
if (didProvideBundleLoader) {
AppleExecutableBinaryInfo executableProvider =
ruleContext.getPrerequisite(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ protected void checkBundleLoaderIsCorrectlyPassedToTheLinker(RuleType ruleType)
assertThat(Joiner.on(" ").join(linkAction.getArguments()))
.contains("-bundle_loader " + getBinArtifact("bin_lipobin", binTarget).getExecPath());
assertThat(Joiner.on(" ").join(linkAction.getArguments()))
.contains("-Wl,-rpath,@loader_path/Frameworks");
.contains("-Xlinker -rpath -Xlinker @loader_path/Frameworks");
}

protected Action lipoLibAction(String libLabel) throws Exception {
Expand Down

0 comments on commit 4f6d6d9

Please sign in to comment.