Skip to content

Commit

Permalink
[5.1] Undocument --bes_best_effort (#15066)
Browse files Browse the repository at this point in the history
We've heared from several people that they tried passing the flag and it did
not have any efect (as expected from a no-op), so let's undocument the flag
so it's no longer discoverable.

On a related note, we should document `--bes_upload_mode` which seems to be
what people want to do.

Closes #14333.

PiperOrigin-RevId: 435317406

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
  • Loading branch information
Wyverald and Yannic authored Mar 17, 2022
1 parent cb6500a commit 4c031d1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,17 @@ public static final class AllCommandGraveyardOptions extends OptionsBase {
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
help = "No-op")
public boolean enableCpuUsageProfiling;

@Option(
name = "bes_best_effort",
defaultValue = "false",
deprecationWarning =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help = "No-op")
public boolean besBestEffort;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,6 @@ public class BuildEventServiceOptions extends OptionsBase {
allowMultiple = true)
public List<Map.Entry<String, String>> besHeaders;

@Option(
name = "bes_best_effort",
defaultValue = "false",
deprecationWarning =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.",
documentationCategory = OptionDocumentationCategory.LOGGING,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.")
public boolean besBestEffort;

@Option(
name = "bes_lifecycle_events",
defaultValue = "true",
Expand Down

0 comments on commit 4c031d1

Please sign in to comment.