Remove attribute read checks expecting a DATA transition.

This is a precursor to removing the DATA transition outright.

While we could also have changed the Mode.DATA instances to
Mode.TARGET (which would declare that we expect the attribute not
to apply any transition), that would break existing definitions and
make depot cleanup more delicate. Plus, these checks weren't being
consistently applied across attributes anyway so they don't really
offer much. A lot of this logic is really just leftover legacy
from the pre-dynamic configuration days.

PiperOrigin-RevId: 198085059

src/main/java/com/google/devtools/build/lib/analysis/LocationExpander.java

@@ -376,7 +376,7 @@ static Map<Label, Collection<Artifact>> buildLocationMap(
     if (allowDataAttributeEntriesInLabel
         && ruleContext.getRule().isAttrDefined("data", BuildType.LABEL_LIST)) {
       Iterables.addAll(depsDataAndTools,
-          ruleContext.getPrerequisitesIf("data", Mode.DATA, FilesToRunProvider.class));
+          ruleContext.getPrerequisitesIf("data", Mode.DONT_CHECK, FilesToRunProvider.class));
     }
     if (ruleContext.getRule().isAttrDefined("tools", BuildType.LABEL_LIST)) {
       Iterables.addAll(depsDataAndTools,

src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java

@@ -1108,11 +1108,9 @@ private void checkAttribute(String attributeName, Mode mode) {
             + " is not configured for the target configuration");
       }
     } else if (mode == Mode.DATA) {
-      if (transition != disableLipoTransition) {
-        throw new IllegalStateException(getRule().getLocation() + ": "
-            + getRuleClassNameForLogging() + " attribute " + attributeName
-            + " is not configured for the data configuration");
-      }
+      throw new IllegalStateException(getRule().getLocation() + ": "
+          + getRuleClassNameForLogging() + " attribute " + attributeName
+          + ": DATA transition no longer supported"); // See b/80157700.
     } else if (mode == Mode.SPLIT) {
       if (!(attributeDefinition.hasSplitConfigurationTransition())) {
         throw new IllegalStateException(getRule().getLocation() + ": "

src/main/java/com/google/devtools/build/lib/analysis/Runfiles.java

@@ -1002,7 +1002,8 @@ public Builder add(RuleContext ruleContext,
      * Collects runfiles from data dependencies of a target.
      */
     public Builder addDataDeps(RuleContext ruleContext) {
-      addTargets(getPrerequisites(ruleContext, "data", Mode.DATA), RunfilesProvider.DATA_RUNFILES);
+      addTargets(getPrerequisites(ruleContext, "data", Mode.DONT_CHECK),
+          RunfilesProvider.DATA_RUNFILES);
       return this;
     }
 

src/main/java/com/google/devtools/build/lib/analysis/RunfilesSupport.java

@@ -104,7 +104,7 @@ private static RunfilesSupport create(
     if (runUnder != null && runUnder.getLabel() != null
         && TargetUtils.isTestRule(ruleContext.getRule())) {
       TransitiveInfoCollection runUnderTarget =
-          ruleContext.getPrerequisite(":run_under", Mode.DATA);
+          ruleContext.getPrerequisite(":run_under", Mode.DONT_CHECK);
       runfiles = new Runfiles.Builder(
           ruleContext.getWorkspaceName(), ruleContext.getConfiguration().legacyExternalRunfiles())
           .merge(getRunfiles(runUnderTarget, ruleContext.getWorkspaceName()))

src/main/java/com/google/devtools/build/lib/analysis/test/TestTargetExecutionSettings.java

@@ -74,7 +74,7 @@ public final class TestTargetExecutionSettings {
 
   private static Artifact getRunUnderExecutable(RuleContext ruleContext) {
     TransitiveInfoCollection runUnderTarget = ruleContext
-        .getPrerequisite(":run_under", Mode.DATA);
+        .getPrerequisite(":run_under", Mode.DONT_CHECK);
     return runUnderTarget == null
         ? null
         : runUnderTarget.getProvider(FilesToRunProvider.class).getExecutable();

src/main/java/com/google/devtools/build/lib/bazel/rules/sh/ShLibrary.java

@@ -36,7 +36,7 @@ public ConfiguredTarget create(RuleContext ruleContext)
     NestedSet<Artifact> filesToBuild = NestedSetBuilder.<Artifact>stableOrder()
         .addAll(ruleContext.getPrerequisiteArtifacts("srcs", Mode.TARGET).list())
         .addAll(ruleContext.getPrerequisiteArtifacts("deps", Mode.TARGET).list())
-        .addAll(ruleContext.getPrerequisiteArtifacts("data", Mode.DATA).list())
+        .addAll(ruleContext.getPrerequisiteArtifacts("data", Mode.DONT_CHECK).list())
         .build();
     Runfiles runfiles = new Runfiles.Builder(
         ruleContext.getWorkspaceName(), ruleContext.getConfiguration().legacyExternalRunfiles())

src/main/java/com/google/devtools/build/lib/rules/android/AndroidInstrumentationTest.java

@@ -256,7 +256,7 @@ private static FilesToRunProvider getAapt(RuleContext ruleContext) {
   }
 
   private static ImmutableList<Artifact> getDataDeps(RuleContext ruleContext) {
-    return ruleContext.getPrerequisiteArtifacts("data", Mode.DATA).list();
+    return ruleContext.getPrerequisiteArtifacts("data", Mode.DONT_CHECK).list();
   }
 
   /**

src/main/java/com/google/devtools/build/lib/rules/extra/ExtraActionFactory.java

@@ -52,7 +52,7 @@ public ConfiguredTarget create(RuleContext context)
     CommandHelper commandHelper =
         new CommandHelper(context, tools, ImmutableMap.<Label, Iterable<Artifact>>of());
 
-    resolvedData.addAll(context.getPrerequisiteArtifacts("data", Mode.DATA).list());
+    resolvedData.addAll(context.getPrerequisiteArtifacts("data", Mode.DONT_CHECK).list());
     List<String>outputTemplates =
         context.attributes().get("out_templates", Type.STRING_LIST);
 

src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java

@@ -365,7 +365,7 @@ protected NestedSet<LinkerInput> collectTransitiveJavaNativeLibraries() {
     builder.addJavaTargets(targetsTreatedAsDeps(ClasspathType.BOTH));
 
     if (ruleContext.getRule().isAttrDefined("data", BuildType.LABEL_LIST)) {
-      builder.addJavaTargets(ruleContext.getPrerequisites("data", Mode.DATA));
+      builder.addJavaTargets(ruleContext.getPrerequisites("data", Mode.DONT_CHECK));
     }
     return builder.build();
   }

src/main/java/com/google/devtools/build/lib/rules/python/PyCommon.java

@@ -480,7 +480,7 @@ public boolean usesSharedLibraries() {
     try {
       return checkForSharedLibraries(Iterables.concat(
               ruleContext.getPrerequisites("deps", Mode.TARGET),
-              ruleContext.getPrerequisites("data", Mode.DATA)));
+              ruleContext.getPrerequisites("data", Mode.DONT_CHECK)));
     } catch (EvalException e) {
       ruleContext.ruleError(e.getMessage());
       return false;